Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac merged PR #224: URL: https://github.com/apache/parquet-format/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.ap

Re: Files with inconsistent num_rows and num_values?

2023-12-05 Thread Micah Kornfield
Thanks for checking. On Tuesday, December 5, 2023, Gang Wu wrote: > I scanned through the parquet-mr implementation. It provides a row-wise > interface to write records in the ColumnWriter. This cannot reproduce > the issue in this thread. I suspect some other implementations may have > their ow

Re: Files with inconsistent num_rows and num_values?

2023-12-05 Thread Gang Wu
I scanned through the parquet-mr implementation. It provides a row-wise interface to write records in the ColumnWriter. This cannot reproduce the issue in this thread. I suspect some other implementations may have their own column-wise column writer implementations and only write pages to the parqu

Re: Fast nullify of columns?

2023-12-05 Thread Gang Wu
Hi Paul, I agree there are better ways to do this, e.g. we can prepare encoded definition levels and repetition levels (if they exist) and directly write the page. However, we need to take care of other rewrite configurations including data page version (v1 or v2), compression, page statistics and

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841970937 Thanks for the suggestion! @kou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: JIRA work log updates

2023-12-05 Thread Gang Wu
Hi Atour, Recently I tried to migrate notifications to different mailing lists by adding a customized asf.yaml file [1]. I may have added too verbose settings to the jira_options key. Let me fix this. [1] https://github.com/apache/parquet-mr/commit/2d10c282f14b6b34a7f3d0a6bf227b881bef5ad5 Best,

JIRA work log updates

2023-12-05 Thread Atour Mousavi Gourabi
Hi everyone, I've been getting [jira] [Work logged] updates in my inbox after comments are added on parquet-mr GitHub PRs for which I am watching the JIRA tickets since short. I suspect this behaviour was introduced at PARQUET-2407 (apache/parquet-mr#1232). As far as I'm aware, we did not log 1

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841024568 > @kou Does the file syntax look ok? I copied this from https://github.com/apache/zookeeper/blob/master/.asf.yaml -- This is an automated message from the Apache Git Service.

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
pitrou commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841021328 @kou Does the file syntax look ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Fix INTERVAL sort order doc in parquet.thrift to be undefined [parquet-format]

2023-12-05 Thread via GitHub
wgtmac merged PR #222: URL: https://github.com/apache/parquet-format/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.ap

Re: [PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac commented on PR #224: URL: https://github.com/apache/parquet-format/pull/224#issuecomment-1841016437 PTAL. Thanks! @pitrou @gszadovszky @shangxinli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] PARQUET-2409: Add custom .asf.yaml for email notification [parquet-format]

2023-12-05 Thread via GitHub
wgtmac opened a new pull request, #224: URL: https://github.com/apache/parquet-format/pull/224 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them i

[jira] [Updated] (PARQUET-2398) Make static variables final

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated PARQUET-2398: Labels: pull-request-available (was: ) > Make static variables final > -