[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-30 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1247575939 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5:

[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-27 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1244236273 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5:

[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-27 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1243891389 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5:

[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-27 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1243814135 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5:

[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-27 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1243416912 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5:

[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-27 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1243409667 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5:

[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-27 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1243234931 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5:

[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-21 Thread via GitHub
gszadovszky commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1237651846 ## src/main/thrift/parquet.thrift: ## @@ -966,6 +985,23 @@ struct ColumnIndex { /** A list containing the number of null values for each page **/ 5: