[GitHub] [parquet-mr] 7c00 commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

2022-07-04 Thread GitBox
7c00 commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1173982766 @shangxinli Thank you for reminding me. I have squashed the PR and added @steveloughran as the co-author. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [parquet-mr] 7c00 commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

2022-06-12 Thread GitBox
7c00 commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1153522439 Thanks @steveloughran @shangxinli . I have cherry-picked the commit from https://github.com/apache/parquet-mr/pull/971 -- This is an automated message from the Apache Git Service. To resp

[GitHub] [parquet-mr] 7c00 commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

2022-05-11 Thread GitBox
7c00 commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1123913274 > @7c00 Do you have time to look into the last feedback? @shangxinli Thanks for your comments. Sorry for late to reply. I think it's ok to add some unit tests, and I am going to do th

[GitHub] [parquet-mr] 7c00 commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

2022-03-08 Thread GitBox
7c00 commented on pull request #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1062551863 Related issue: https://github.com/prestodb/presto/pull/17435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and