[GitHub] [parquet-mr] belugabehr commented on pull request #815: PARQUET-1776: NIO wrapper for Output/Input File

2020-09-22 Thread GitBox
belugabehr commented on pull request #815: URL: https://github.com/apache/parquet-mr/pull/815#issuecomment-696754782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [parquet-mr] belugabehr commented on pull request #815: PARQUET-1776: NIO wrapper for Output/Input File

2020-09-22 Thread GitBox
belugabehr commented on pull request #815: URL: https://github.com/apache/parquet-mr/pull/815#issuecomment-696929711 Here are a couple of starters: ``` private final ByteBuffer oneByteBuffer = ByteBuffer.allocate(1); @Override public int read() throws IOE

[GitHub] [parquet-mr] belugabehr commented on pull request #815: PARQUET-1776: NIO wrapper for Output/Input File

2020-09-22 Thread GitBox
belugabehr commented on pull request #815: URL: https://github.com/apache/parquet-mr/pull/815#issuecomment-69670 Also requires unit tests. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [parquet-mr] belugabehr commented on pull request #815: PARQUET-1776: NIO wrapper for Output/Input File

2020-09-22 Thread GitBox
belugabehr commented on pull request #815: URL: https://github.com/apache/parquet-mr/pull/815#issuecomment-696754782 @HunterL OK, so I've been recently diving into Java NIO a bit and let me add some thoughts that relate to this task: Please change the naming convention and dr