[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411741293 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java ## @@ -919,6 +895,59 @@ public void

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411711834 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* Review comment: Same issue

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411711834 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* Review comment: Same issue

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411708296 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache Software

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411696939 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache Software

[GitHub] [parquet-mr] brimzi commented on a change in pull request #775: PARQUET-1381: add parquet block merging feature

2020-04-20 Thread GitBox
brimzi commented on a change in pull request #775: URL: https://github.com/apache/parquet-mr/pull/775#discussion_r411692398 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/RowGroupMerger.java ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache Software