[GitHub] [parquet-mr] dossett commented on pull request #959: PARQUET-2126: Make cached (de)compressors thread-safe

2022-06-09 Thread GitBox
dossett commented on PR #959: URL: https://github.com/apache/parquet-mr/pull/959#issuecomment-1151467318 @shangxinli I do not feel strongly about it. I think historical context is better kept in JIRAs and PR discussion than in code comments, but that is just a style choice if there's no st

[GitHub] [parquet-mr] dossett commented on pull request #959: PARQUET-2126: Make cached (de)compressors thread-safe

2022-04-22 Thread GitBox
dossett commented on PR #959: URL: https://github.com/apache/parquet-mr/pull/959#issuecomment-1106556192 Seems good to me (non-binding!). Revisiting whether or not the caching strategy make sense might be worthwhile, but that shouldn't stop this fix. Small comment: I would remove mo

[GitHub] [parquet-mr] dossett commented on pull request #959: PARQUET-2126: Make cached (de)compressors thread-safe

2022-04-22 Thread GitBox
dossett commented on PR #959: URL: https://github.com/apache/parquet-mr/pull/959#issuecomment-1106556193 Seems good to me (non-binding!). Revisiting whether or not the caching strategy make sense might be worthwhile, but that shouldn't stop this fix. Small comment: I would remove mo