[GitHub] [parquet-mr] jinyius commented on pull request #988: PARQUET-1711: Break circular dependencies in proto definitions

2022-10-09 Thread GitBox
jinyius commented on PR #988: URL: https://github.com/apache/parquet-mr/pull/988#issuecomment-1272784474 > Hi @jinyius and @matthieun, Thank both of you for the contribution and we really appreciate your patience with us. Now we have two PRs for the same issue, we better merge them into

[GitHub] [parquet-mr] jinyius commented on pull request #988: PARQUET-1711: Break circular dependencies in proto definitions

2022-09-27 Thread GitBox
jinyius commented on PR #988: URL: https://github.com/apache/parquet-mr/pull/988#issuecomment-1260420022 > @matthieun and @jinyius Would it be possible for you both to sync to come up with one solution? You can put the other one as co-author. imho, i believe #995 is a superset of

[GitHub] [parquet-mr] jinyius commented on pull request #988: PARQUET-1711: Break circular dependencies in proto definitions

2022-09-08 Thread GitBox
jinyius commented on PR #988: URL: https://github.com/apache/parquet-mr/pull/988#issuecomment-1240350078 fyi, i sent pr #995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [parquet-mr] jinyius commented on pull request #988: PARQUET-1711: Break circular dependencies in proto definitions

2022-08-30 Thread GitBox
jinyius commented on PR #988: URL: https://github.com/apache/parquet-mr/pull/988#issuecomment-1232470935 hmm... what timing. i actually have a pr for what i think is a more robust approach that truncates at an arbitrary recursion depth by putting the remaining recursion levels into a