[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #954: PARQUET-2136: File writer construction with encryptor

2022-04-14 Thread GitBox
shangxinli commented on code in PR #954: URL: https://github.com/apache/parquet-mr/pull/954#discussion_r850595178 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java: ## @@ -336,20 +354,30 @@ public ParquetFileWriter(OutputFile file, MessageType

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #954: PARQUET-2136: File writer construction with encryptor

2022-04-14 Thread GitBox
shangxinli commented on code in PR #954: URL: https://github.com/apache/parquet-mr/pull/954#discussion_r850550025 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java: ## @@ -336,20 +354,30 @@ public ParquetFileWriter(OutputFile file, MessageType

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #954: PARQUET-2136: File writer construction with encryptor

2022-04-14 Thread GitBox
shangxinli commented on code in PR #954: URL: https://github.com/apache/parquet-mr/pull/954#discussion_r850550025 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java: ## @@ -336,20 +354,30 @@ public ParquetFileWriter(OutputFile file, MessageType

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #954: PARQUET-2136: File writer construction with encryptor

2022-04-14 Thread GitBox
shangxinli commented on code in PR #954: URL: https://github.com/apache/parquet-mr/pull/954#discussion_r850523822 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java: ## @@ -336,20 +354,30 @@ public ParquetFileWriter(OutputFile file, MessageType