[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

2022-07-24 Thread GitBox
shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r928310312 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead( GenericData

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

2022-06-17 Thread GitBox
shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r900688194 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead( GenericData

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

2022-06-17 Thread GitBox
shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r900687324 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead( GenericData

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

2022-06-17 Thread GitBox
shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r900687175 ## parquet-avro/src/test/java/org/apache/parquet/avro/TestArrayListCompatibility.java: ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

2022-05-11 Thread GitBox
shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r870479919 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java: ## @@ -866,6 +866,20 @@ static boolean isElementType(Type repeatedType, Schema