shangxinli commented on PR #1000:
URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1300583034
LGTM, let's see if there are comments from others, otherwise we can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shangxinli commented on PR #1000:
URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1281720715
Hm... any opinion on this @ggershinsky ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
shangxinli commented on PR #1000:
URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1281244709
Looks good. The only thing is we checked in binary files directly. It would
be hard to maintain in the future. Can you generate the parquet file using the
parquetwriter?
--
shangxinli commented on PR #1000:
URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1259976087
Nice implementation! For the test, can you add more for interop with lz4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shangxinli commented on PR #1000:
URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1259621617
Thank Gang for contributing! Is there any benchmarking numbers? Any
comparison with ZSTD? These are non-blocking question for review and merging.
--
This is an automated message
