[GitHub] [parquet-mr] shangxinli commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-07-24 Thread GitBox
shangxinli commented on PR #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-1193386419 I think we are close to merge this PR. Resolve the conflict and use the imports , then we can merge. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [parquet-mr] shangxinli commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-04-20 Thread GitBox
shangxinli commented on PR #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-1104043913 @mwong38 Can you address the feedback from @emkornfield before we can merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [parquet-mr] shangxinli commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-03-25 Thread GitBox
shangxinli commented on pull request #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-1079368200 Will have another look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [parquet-mr] shangxinli commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-03-19 Thread GitBox
shangxinli commented on pull request #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-1073074540 Can you squash all the commits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [parquet-mr] shangxinli commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-03-07 Thread GitBox
shangxinli commented on pull request #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-1060883376 I don't see a reason why this cannot be merge. I will have a look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [parquet-mr] shangxinli commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2021-11-12 Thread GitBox
shangxinli commented on pull request #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-967285427 @mwong38, can you put more information in the Jira on why/what is changed? This is pretty big change and it would help people to review your code. -- This is an automated