theosib-amazon commented on PR #953:
URL: https://github.com/apache/parquet-mr/pull/953#issuecomment-1108960499
Also, you mentioned tests. Since I'm not making any functional changes, I'm
not sure what to test for. The new code should behave exactly as the old
version, just a bit faster.
theosib-amazon commented on PR #953:
URL: https://github.com/apache/parquet-mr/pull/953#issuecomment-1108891240
I made all the cosmetic changes you asked for.
I'm not sure why you're asking to separate the ByteBufferInputStream
additions into its own PR, since the PR was all about
theosib-amazon commented on pull request #953:
URL: https://github.com/apache/parquet-mr/pull/953#issuecomment-1081948012
I forgot to add this to a comment in the code:
The reason PlainValuesReader still includes an unused
LittleEndianDataInputStream member is because if I don't, the
