Re: [PR] PARQUET-2382: Remove the deprecated `OriginalType` [parquet-mr]

2023-11-24 Thread via GitHub
Fokko commented on PR #1194: URL: https://github.com/apache/parquet-mr/pull/1194#issuecomment-1825293064 Makes sense. I think it would be good to remove `OriginalType` at some point. Let's target this PR for 2.0 and leave it for now. I'll create another PR to mark the `getOriginalType()`

Re: [PR] PARQUET-2382: Remove the deprecated `OriginalType` [parquet-mr]

2023-11-17 Thread via GitHub
gszadovszky commented on PR #1194: URL: https://github.com/apache/parquet-mr/pull/1194#issuecomment-1815995828 I don't think it is a good idea to remove deprecated API in a minor release. That's why we have japicmp to ensure backward compatibility. I think, there is no harm for Parquet

Re: [PR] PARQUET-2382: Remove the deprecated `OriginalType` [parquet-mr]

2023-11-16 Thread via GitHub
wgtmac commented on PR #1194: URL: https://github.com/apache/parquet-mr/pull/1194#issuecomment-1814785912 I am fine with it but I'd like to seek advices from @gszadovszky @shangxinli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] PARQUET-2382: Remove the deprecated OriginalType [parquet-mr]

2023-11-15 Thread via GitHub
Fokko commented on code in PR #1194: URL: https://github.com/apache/parquet-mr/pull/1194#discussion_r1394558775 ## parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java: ## @@ -1715,15 +1729,15 @@ private void