[jira] [Commented] (PARQUET-1533) TestSnappy() throws OOM exception with Parquet-1485 change

[ https://issues.apache.org/jira/browse/PARQUET-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771730#comment-16771730 ] Gabor Szadovszky commented on PARQUET-1533: --- Thanks a lot, [~sha...@uber.com] for creating

Re: [DISCUSS] Upgrade to Jackson 2.x and remove the shading

Hi, Ryan The ticket that I mentioned is indeed outdated, thanks for closing it. In fact it is solved as a side effect of PARQUET-1529( https://github.com/apache/parquet-mr/pull/617), which adds maven-shade-plugin to the package phase and thus relocates jackson packages. But my point is: It seems

[jira] [Commented] (PARQUET-1381) Add merge blocks command to parquet-tools

[ https://issues.apache.org/jira/browse/PARQUET-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772080#comment-16772080 ] Gabor Szadovszky commented on PARQUET-1381: --- The design of this feature has conceptional

Re: Reverting the merge blocks command feature

Sorry, wrong PR. So, see PARQUET-1381 and PR #621 . On Tue, Feb 19, 2019 at 5:44 PM Gabor Szadovszky wrote: > Hi All, > > During working on a fix I've discovered that the recently added (since >

[jira] [Commented] (PARQUET-1381) Add merge blocks command to parquet-tools

[ https://issues.apache.org/jira/browse/PARQUET-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772081#comment-16772081 ] ASF GitHub Bot commented on PARQUET-1381: - gszadovszky commented on pull request #621: Revert

Reverting the merge blocks command feature

Hi All, During working on a fix I've discovered that the recently added (since 1.10.0) feature PARQUET-1381 is not properly implemented and causes some unit test failures with my independent fix. After a more deep investigation I think the design of this feature is conceptionally incompatible

[jira] [Updated] (PARQUET-1533) TestSnappy() throws OOM exception with Parquet-1485 change

[ https://issues.apache.org/jira/browse/PARQUET-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Ivanfi updated PARQUET-1533: --- Description: Parquet-1485 initialize the buffer size(inputBuffer and outputBuffer) from 0

Re: [DISCUSS] Upgrade to Jackson 2.x and remove the shading

Thanks all for the feedback. I've updated the PR to shade Jackson 2.x as well based on the feedback of the thread. Personally, I haven't had that much issues with the latest versions of Jackson, but let us stay on the safe side. Jackson is still being used in: - parquet-cli - parquet-hadoop -

Re: [DISCUSS] Upgrade to Jackson 2.x and remove the shading

The difference between Jackson and fastutil is that Jackson is used in several modules. Instead of shading the classes into each one, we created a module. If I remember correctly, fastutil is used and shaded in just one module. If you want to improve how the plugin is called, that would be great.