[jira] [Commented] (PARQUET-1719) Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public
[
https://issues.apache.org/jira/browse/PARQUET-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486058#comment-17486058
]
ASF GitHub Bot commented on PARQUET-1719:
-
shangxinli commented on a change in pull request #707:
URL: https://github.com/apache/parquet-mr/pull/707#discussion_r797956093
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java
##
@@ -115,9 +115,9 @@ private ParquetReader(Configuration conf,
readSupport);
}
- private ParquetReader(List files,
-ParquetReadOptions options,
-ReadSupport readSupport) throws IOException {
+ public ParquetReader(List files,
Review comment:
Since it is going be public, please add comments like above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make ParquetReader(List, ParquetReadOptions, ReadSupport)
> constructor public
> --
>
> Key: PARQUET-1719
> URL: https://issues.apache.org/jira/browse/PARQUET-1719
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
>Reporter: Dmitry Sysolyatin
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
>
> My application uses s3 storage to store parquet files. The problem is that
> there is not ability to get rid from `new Configuration(true);` which load
> configuration from files:
> `core-default.xml` and `core-site.xml` every time when ParquetReader instance
> is created.
> I suggest just make ParquetReader(List, ParquetReadOptions,
> ReadSupport) constructor public then there will be ability to do custom
> builder.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [parquet-mr] shangxinli commented on a change in pull request #707: [PARQUET-1719] Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public
shangxinli commented on a change in pull request #707:
URL: https://github.com/apache/parquet-mr/pull/707#discussion_r797956093
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java
##
@@ -115,9 +115,9 @@ private ParquetReader(Configuration conf,
readSupport);
}
- private ParquetReader(List files,
-ParquetReadOptions options,
-ReadSupport readSupport) throws IOException {
+ public ParquetReader(List files,
Review comment:
Since it is going be public, please add comments like above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PARQUET-2117) Add rowPosition API in parquet record readers
[ https://issues.apache.org/jira/browse/PARQUET-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485949#comment-17485949 ] Xinli Shang commented on PARQUET-2117: -- Thanks for opening this Jira! Look forward to the PR. > Add rowPosition API in parquet record readers > - > > Key: PARQUET-2117 > URL: https://issues.apache.org/jira/browse/PARQUET-2117 > Project: Parquet > Issue Type: New Feature > Components: parquet-mr >Reporter: Prakhar Jain >Priority: Major > Fix For: 1.13.0 > > > Currently the parquet-mr RecordReader/ParquetFileReader exposes API’s to read > parquet file in columnar fashion or record-by-record. > It will be great to extend them to also support rowPosition API which can > tell the position of the current record in the parquet file. > The rowPosition can be used as a unique row identifier to mark a row. This > can be useful to create an index (e.g. B+ tree) over a parquet file/parquet > table (e.g. Spark/Hive). > There are multiple projects in the parquet eco-system which can benefit from > such a functionality: > # Apache Iceberg needs this functionality. It has this implementation > already as it relies on low level parquet APIs - > [Link1|https://github.com/apache/iceberg/blob/apache-iceberg-0.12.1/parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java#L171], > > [Link2|https://github.com/apache/iceberg/blob/d4052a73f14b63e1f519aaa722971dc74f8c9796/core/src/main/java/org/apache/iceberg/MetadataColumns.java#L37] > # Apache Spark can use this functionality - SPARK-37980 -- This message was sent by Atlassian Jira (v8.20.1#820001)
