[jira] [Commented] (PARQUET-1166) [API Proposal] Add GetRecordBatchReader in parquet/arrow/reader.h

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412375#comment-16412375 ] ASF GitHub Bot commented on PARQUET-1166: - advancedxy commented on a change in pull request

[jira] [Commented] (PARQUET-1222) Definition of float and double sort order is ambiguous

2018-03-23 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412154#comment-16412154 ] Ryan Blue commented on PARQUET-1222: I think Jim is right. IEEE-754 numbers are ordered correctly if

[jira] [Assigned] (PARQUET-1166) [API Proposal] Add GetRecordBatchReader in parquet/arrow/reader.h

2018-03-23 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney reassigned PARQUET-1166: - Assignee: Xianjin YE > [API Proposal] Add GetRecordBatchReader in

[jira] [Resolved] (PARQUET-1166) [API Proposal] Add GetRecordBatchReader in parquet/arrow/reader.h

2018-03-23 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney resolved PARQUET-1166. --- Resolution: Fixed Fix Version/s: cpp-1.5.0 Issue resolved by pull request 445

[jira] [Commented] (PARQUET-1166) [API Proposal] Add GetRecordBatchReader in parquet/arrow/reader.h

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411969#comment-16411969 ] ASF GitHub Bot commented on PARQUET-1166: - wesm commented on a change in pull request #445:

[jira] [Commented] (PARQUET-1166) [API Proposal] Add GetRecordBatchReader in parquet/arrow/reader.h

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411968#comment-16411968 ] ASF GitHub Bot commented on PARQUET-1166: - wesm commented on a change in pull request #445:

[jira] [Commented] (PARQUET-1249) Clarify encoding schemes for boolean types

2018-03-23 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411943#comment-16411943 ] Chao Sun commented on PARQUET-1249: --- Thanks! > Clarify encoding schemes for boolean types >

[jira] [Assigned] (PARQUET-1249) Clarify encoding schemes for boolean types

2018-03-23 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Sun reassigned PARQUET-1249: - Assignee: Chao Sun > Clarify encoding schemes for boolean types >

[jira] [Commented] (PARQUET-1249) Clarify encoding schemes for boolean types

2018-03-23 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411940#comment-16411940 ] Wes McKinney commented on PARQUET-1249: --- Added you > Clarify encoding schemes for boolean types >

[jira] [Commented] (PARQUET-1249) Clarify encoding schemes for boolean types

2018-03-23 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411939#comment-16411939 ] Chao Sun commented on PARQUET-1249: --- Trying to make my first contribution here. Can someone add me as

Re: FW: RE: Windows Static Libs

2018-03-23 Thread Wes McKinney
hi Sam We are testing the Static CRT build without conda toolchain in our Appveyor setup: https://github.com/apache/parquet-cpp/blob/master/ci/msvc-build.bat#L54 Hope this does what you need Wes On Wed, Mar 21, 2018 at 9:56 AM, wrote: > > The only published instructions

Re: Merging changes in the GitBox era

2018-03-23 Thread Wes McKinney
+1 On Fri, Mar 23, 2018 at 1:56 PM, Lars Volker wrote: > I checked with the Infra team and they can disable some of the options for > us. Before opening a Jira I'd like to get some more feedback here. The > options are: > >- Disable Merge commits >- Keep "Squash and

Re: Merging changes in the GitBox era

2018-03-23 Thread Lars Volker
I checked with the Infra team and they can disable some of the options for us. Before opening a Jira I'd like to get some more feedback here. The options are: - Disable Merge commits - Keep "Squash and Merge" and "Rebase and Merge" - Keep "Squash and Merge" as the default. This is what

Re: Merging changes in the GitBox era

2018-03-23 Thread Wes McKinney
You may be able to ask ASF Infra to disallow merge commits in the GitHub UI to prevent this from happening On Fri, Mar 23, 2018 at 11:18 AM, Lars Volker wrote: > Both of these merges are on me, I wasn't aware aware that they would show > up like this. I personally prefer the

Re: Merging changes in the GitBox era

2018-03-23 Thread Lars Volker
Both of these merges are on me, I wasn't aware aware that they would show up like this. I personally prefer the format provided by the dev/merge.py script. Since 2016 Github supports "Rebase and Merge" as a second option when submitting PRs:

[jira] [Commented] (PARQUET-1242) parquet.thrift refers to wrong releases for the new compressions

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411419#comment-16411419 ] ASF GitHub Bot commented on PARQUET-1242: - zivanfi closed pull request #87: PARQUET-1242:

[jira] [Commented] (PARQUET-1166) [API Proposal] Add GetRecordBatchReader in parquet/arrow/reader.h

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411391#comment-16411391 ] ASF GitHub Bot commented on PARQUET-1166: - xhochy commented on issue #445: [WIP] PARQUET-1166:

Merging changes in the GitBox era

2018-03-23 Thread Zoltan Ivanfi
Hi, Parquet was recently migrated to GitBox (thanks, Uwe!). The dev/merge.py script can be still used by setting PUSH_REMOTE_NAME=apache-github before invoking it. There is also a new option of merging changes using the GitHub web UI. I personally continued using the merge script, while others

[jira] [Commented] (PARQUET-1211) Write column indexes: read/write API

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411047#comment-16411047 ] ASF GitHub Bot commented on PARQUET-1211: - gszadovszky commented on a change in pull request

[jira] [Commented] (PARQUET-1211) Write column indexes: read/write API

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411035#comment-16411035 ] ASF GitHub Bot commented on PARQUET-1211: - legend-hua commented on a change in pull request

[jira] [Commented] (PARQUET-1211) Write column indexes: read/write API

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411018#comment-16411018 ] ASF GitHub Bot commented on PARQUET-1211: - gszadovszky commented on a change in pull request

[jira] [Commented] (PARQUET-1211) Write column indexes: read/write API

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411017#comment-16411017 ] ASF GitHub Bot commented on PARQUET-1211: - gszadovszky commented on a change in pull request

[jira] [Commented] (PARQUET-1211) Write column indexes: read/write API

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410996#comment-16410996 ] ASF GitHub Bot commented on PARQUET-1211: - legend-hua commented on a change in pull request

[jira] [Commented] (PARQUET-1211) Write column indexes: read/write API

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410995#comment-16410995 ] ASF GitHub Bot commented on PARQUET-1211: - legend-hua commented on a change in pull request