[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135906#comment-17135906 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky edited a comment on pull request #615:

[GitHub] [parquet-mr] ggershinsky edited a comment on pull request #615: PARQUET-1373: Encryption key tools

2020-06-15 Thread GitBox
ggershinsky edited a comment on pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#issuecomment-644145175 > > ConcurrentMap has a segment synchronization for write operations, and allows for synchronization-free read operations; this makes it faster than HasMap with

[GitHub] [parquet-mr] ggershinsky commented on pull request #615: PARQUET-1373: Encryption key tools

2020-06-15 Thread GitBox
ggershinsky commented on pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#issuecomment-644145175 > > ConcurrentMap has a segment synchronization for write operations, and allows for synchronization-free read operations; this makes it faster than HasMap with

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135871#comment-17135871 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on pull request #615: URL:

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135788#comment-17135788 ] ASF GitHub Bot commented on PARQUET-1373: - gszadovszky commented on a change in pull request

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-15 Thread GitBox
gszadovszky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r439346745 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/PropertiesDrivenCryptoFactory.java ## @@ -0,0 +1,203 @@ +/* + *

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135619#comment-17135619 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-15 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r440027472 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/HadoopFSKeyMaterialStore.java ## @@ -0,0 +1,127 @@ +/* + * Licensed

[jira] [Commented] (PARQUET-1876) Port ZSTD-JNI support to 1.10.x brach

2020-06-15 Thread Gabor Szadovszky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135557#comment-17135557 ] Gabor Szadovszky commented on PARQUET-1876: --- I don't think this is a bug. This is a feature

[jira] [Commented] (PARQUET-1373) Encryption key management tools

2020-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135456#comment-17135456 ] ASF GitHub Bot commented on PARQUET-1373: - ggershinsky commented on a change in pull request

[GitHub] [parquet-mr] ggershinsky commented on a change in pull request #615: PARQUET-1373: Encryption key tools

2020-06-15 Thread GitBox
ggershinsky commented on a change in pull request #615: URL: https://github.com/apache/parquet-mr/pull/615#discussion_r439953778 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PARQUET-1866) Replace Hadoop ZSTD with JNI-ZSTD

2020-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135432#comment-17135432 ] ASF GitHub Bot commented on PARQUET-1866: - dbtsai commented on pull request #797: URL:

[GitHub] [parquet-mr] dbtsai commented on pull request #797: PARQUET-1866: Replace Hadoop ZSTD with JNI-ZSTD (#793)

2020-06-15 Thread GitBox
dbtsai commented on pull request #797: URL: https://github.com/apache/parquet-mr/pull/797#issuecomment-643920535 LGTM. This will help Spark community to adopt zstd easier. Thanks for the great work! This is an automated