[jira] [Commented] (PARQUET-2063) Remove Compile Warnings from MemoryManager
[ https://issues.apache.org/jira/browse/PARQUET-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379464#comment-17379464 ] ASF GitHub Bot commented on PARQUET-2063: - shangxinli commented on pull request #917: URL: https://github.com/apache/parquet-mr/pull/917#issuecomment-878665045 > I've restarted the Travis build the second time. Not sure why it fails, there are no logs at all. Yeah, I am seeing the same error in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove Compile Warnings from MemoryManager > -- > > Key: PARQUET-2063 > URL: https://issues.apache.org/jira/browse/PARQUET-2063 > Project: Parquet > Issue Type: Improvement > Components: parquet-mr >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [parquet-mr] shangxinli commented on pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
shangxinli commented on pull request #917: URL: https://github.com/apache/parquet-mr/pull/917#issuecomment-878665045 > I've restarted the Travis build the second time. Not sure why it fails, there are no logs at all. Yeah, I am seeing the same error in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PARQUET-2064) Make Range public accessible in RowRanges
[ https://issues.apache.org/jira/browse/PARQUET-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379348#comment-17379348 ] ASF GitHub Bot commented on PARQUET-2064: - sunchao commented on pull request #918: URL: https://github.com/apache/parquet-mr/pull/918#issuecomment-878420122 @shangxinli sure I can make a PR after this one is done - it depends on making the `Range` class public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make Range public accessible in RowRanges > - > > Key: PARQUET-2064 > URL: https://issues.apache.org/jira/browse/PARQUET-2064 > Project: Parquet > Issue Type: New Feature >Reporter: Xinli Shang >Assignee: Xinli Shang >Priority: Major > > When rolling out to Presto, I found we need to know the boundaries of each > Range in RowRanges. It is still doable with Iterator but Presto has. batch > reader, we cannot use iterator for each row. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [parquet-mr] sunchao commented on pull request #918: PARQUET-2064: Make Range public accessible in RowRanges
sunchao commented on pull request #918: URL: https://github.com/apache/parquet-mr/pull/918#issuecomment-878420122 @shangxinli sure I can make a PR after this one is done - it depends on making the `Range` class public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PARQUET-2064) Make Range public accessible in RowRanges
[ https://issues.apache.org/jira/browse/PARQUET-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379219#comment-17379219 ] Gabor Szadovszky commented on PARQUET-2064: --- [~sha...@uber.com], sorry if I was misleading. I do agree to make the required classes/methods public if it makes our clients' lives easier. > Make Range public accessible in RowRanges > - > > Key: PARQUET-2064 > URL: https://issues.apache.org/jira/browse/PARQUET-2064 > Project: Parquet > Issue Type: New Feature >Reporter: Xinli Shang >Assignee: Xinli Shang >Priority: Major > > When rolling out to Presto, I found we need to know the boundaries of each > Range in RowRanges. It is still doable with Iterator but Presto has. batch > reader, we cannot use iterator for each row. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PARQUET-2064) Make Range public accessible in RowRanges
[ https://issues.apache.org/jira/browse/PARQUET-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379217#comment-17379217 ] Xinli Shang commented on PARQUET-2064: -- [~gszadovszky], do you have some suggestions on how to proceed? It is the reality that Spar/Hive uses lower-level APIs that were not designed for and it is now a blocker for column index to rollout. > Make Range public accessible in RowRanges > - > > Key: PARQUET-2064 > URL: https://issues.apache.org/jira/browse/PARQUET-2064 > Project: Parquet > Issue Type: New Feature >Reporter: Xinli Shang >Assignee: Xinli Shang >Priority: Major > > When rolling out to Presto, I found we need to know the boundaries of each > Range in RowRanges. It is still doable with Iterator but Presto has. batch > reader, we cannot use iterator for each row. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PARQUET-2064) Make Range public accessible in RowRanges
[ https://issues.apache.org/jira/browse/PARQUET-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379001#comment-17379001 ] ASF GitHub Bot commented on PARQUET-2064: - gszadovszky commented on pull request #918: URL: https://github.com/apache/parquet-mr/pull/918#issuecomment-878037608 @shangxinli, unfortunately we still struggle with not having proper low level API for our clients. We did not add the ranges and such to the public API because they should not be required there. Since both Spark and Hive uses lower level APIs (that was not designed to be public originally) I don't think we have any other choice for now to make all the necessary classes/methods public. Meanwhile, I've added `RowRanges` to the package `org.apache.parquet.internal.filter2.columnindex` (note `internal`) to make it clear that even though the class is public it is not for our clients. So, if we really want to make this public we also need to move it to another package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make Range public accessible in RowRanges > - > > Key: PARQUET-2064 > URL: https://issues.apache.org/jira/browse/PARQUET-2064 > Project: Parquet > Issue Type: New Feature >Reporter: Xinli Shang >Assignee: Xinli Shang >Priority: Major > > When rolling out to Presto, I found we need to know the boundaries of each > Range in RowRanges. It is still doable with Iterator but Presto has. batch > reader, we cannot use iterator for each row. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [parquet-mr] gszadovszky commented on pull request #918: PARQUET-2064: Make Range public accessible in RowRanges
gszadovszky commented on pull request #918: URL: https://github.com/apache/parquet-mr/pull/918#issuecomment-878037608 @shangxinli, unfortunately we still struggle with not having proper low level API for our clients. We did not add the ranges and such to the public API because they should not be required there. Since both Spark and Hive uses lower level APIs (that was not designed to be public originally) I don't think we have any other choice for now to make all the necessary classes/methods public. Meanwhile, I've added `RowRanges` to the package `org.apache.parquet.internal.filter2.columnindex` (note `internal`) to make it clear that even though the class is public it is not for our clients. So, if we really want to make this public we also need to move it to another package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
