[jira] [Commented] (PARQUET-2106) BinaryComparator should avoid doing ByteBuffer.wrap in the hot-path
[ https://issues.apache.org/jira/browse/PARQUET-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455908#comment-17455908 ] ASF GitHub Bot commented on PARQUET-2106: - alexeykudinkin commented on pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#issuecomment-989042060 My bad. Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BinaryComparator should avoid doing ByteBuffer.wrap in the hot-path > --- > > Key: PARQUET-2106 > URL: https://issues.apache.org/jira/browse/PARQUET-2106 > Project: Parquet > Issue Type: Task > Components: parquet-mr >Affects Versions: 1.12.2 >Reporter: Alexey Kudinkin >Priority: Major > Attachments: Screen Shot 2021-12-03 at 3.26.31 PM.png, > profile_48449_alloc_1638494450_sort_by.html > > > *Background* > While writing out large Parquet tables using Spark, we've noticed that > BinaryComparator is the source of substantial churn of extremely short-lived > `HeapByteBuffer` objects – It's taking up to *16%* of total amount of > allocations in our benchmarks, putting substantial pressure on a Garbage > Collector: > !Screen Shot 2021-12-03 at 3.26.31 PM.png|width=828,height=521! > [^profile_48449_alloc_1638494450_sort_by.html] > > *Proposal* > We're proposing to adjust lexicographical comparison (at least) to avoid > doing any allocations, since this code lies on the hot-path of every Parquet > write, therefore causing substantial churn amplification. > > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [parquet-mr] alexeykudinkin commented on pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path
alexeykudinkin commented on pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#issuecomment-989042060 My bad. Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (PARQUET-2107) Travis failures
[ https://issues.apache.org/jira/browse/PARQUET-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky resolved PARQUET-2107. --- Resolution: Fixed > Travis failures > --- > > Key: PARQUET-2107 > URL: https://issues.apache.org/jira/browse/PARQUET-2107 > Project: Parquet > Issue Type: Bug >Reporter: Gabor Szadovszky >Assignee: Gabor Szadovszky >Priority: Major > > There are Travis failures since a while in our PRs. See e.g. > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598285 or > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598286 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PARQUET-2106) BinaryComparator should avoid doing ByteBuffer.wrap in the hot-path
[
https://issues.apache.org/jira/browse/PARQUET-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455060#comment-17455060
]
ASF GitHub Bot commented on PARQUET-2106:
-
gszadovszky commented on a change in pull request #940:
URL: https://github.com/apache/parquet-mr/pull/940#discussion_r764664867
##
File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
##
@@ -542,6 +606,10 @@ public static Binary fromCharSequence(CharSequence value) {
return new FromCharSequenceBinary(value);
}
+ public static int lexicographicCompareTo(Binary one, Binary other) {
Review comment:
Still contains `To`.
```suggestion
public static int lexicographicCompare(Binary one, Binary other) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> BinaryComparator should avoid doing ByteBuffer.wrap in the hot-path
> ---
>
> Key: PARQUET-2106
> URL: https://issues.apache.org/jira/browse/PARQUET-2106
> Project: Parquet
> Issue Type: Task
> Components: parquet-mr
>Affects Versions: 1.12.2
>Reporter: Alexey Kudinkin
>Priority: Major
> Attachments: Screen Shot 2021-12-03 at 3.26.31 PM.png,
> profile_48449_alloc_1638494450_sort_by.html
>
>
> *Background*
> While writing out large Parquet tables using Spark, we've noticed that
> BinaryComparator is the source of substantial churn of extremely short-lived
> `HeapByteBuffer` objects – It's taking up to *16%* of total amount of
> allocations in our benchmarks, putting substantial pressure on a Garbage
> Collector:
> !Screen Shot 2021-12-03 at 3.26.31 PM.png|width=828,height=521!
> [^profile_48449_alloc_1638494450_sort_by.html]
>
> *Proposal*
> We're proposing to adjust lexicographical comparison (at least) to avoid
> doing any allocations, since this code lies on the hot-path of every Parquet
> write, therefore causing substantial churn amplification.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path
gszadovszky commented on a change in pull request #940:
URL: https://github.com/apache/parquet-mr/pull/940#discussion_r764664867
##
File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
##
@@ -542,6 +606,10 @@ public static Binary fromCharSequence(CharSequence value) {
return new FromCharSequenceBinary(value);
}
+ public static int lexicographicCompareTo(Binary one, Binary other) {
Review comment:
Still contains `To`.
```suggestion
public static int lexicographicCompare(Binary one, Binary other) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
