[jira] [Commented] (PARQUET-2181) parquet-cli fails at supporting parquet-protobuf generated files

2022-09-07 Thread J Y (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601491#comment-17601491 ] J Y commented on PARQUET-2181: -- [~theosib-amazon], i think they're similar in that there's

[jira] [Commented] (PARQUET-2181) parquet-cli fails at supporting parquet-protobuf generated files

2022-09-07 Thread Timothy Miller (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601415#comment-17601415 ] Timothy Miller commented on PARQUET-2181: - Is this related to PARQUET-2069? Or

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965076867 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public b

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965074182 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -138,6 +134,18 @@ public int read(byte[] b, int off, int len) throws

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965065058 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -138,6 +134,18 @@ public int read(byte[] b, int off, int len) throws

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965063218 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -379,4 +427,120 @@ public void remove() { second.remove();

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965058610 ## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ## @@ -88,6 +136,21 @@ public long skip(long n) { return bytesToSkip;

[jira] [Commented] (PARQUET-2185) ParquetReader constructed using builder fails to read encrypted files

2022-09-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601389#comment-17601389 ] ASF GitHub Bot commented on PARQUET-2185: - a2l007 opened a new pull request, #9

[GitHub] [parquet-mr] a2l007 opened a new pull request, #994: PARQUET-2185 ParquetReader constructed using builder fails to read encrypted files

2022-09-07 Thread GitBox
a2l007 opened a new pull request, #994: URL: https://github.com/apache/parquet-mr/pull/994 This PR fixes the nullpointer exception encountered while reading encrypted files using the ParquetReader initialized using the builder. It modifies the existing `ParquetReadOptions.Builder` initializ

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965054827 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) {

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965053720 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) {

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965052612 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public b

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-09-07 Thread GitBox
theosib-amazon commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965051616 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public b

[jira] [Updated] (PARQUET-2185) ParquetReader constructed using builder fails to read encrypted files

2022-09-07 Thread Atul Mohan (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Mohan updated PARQUET-2185: Description: ParquetReader objects can be constructed using the builder as follows:  {code:java}

[jira] [Updated] (PARQUET-2185) ParquetReader constructed using builder fails to read encrypted files

2022-09-07 Thread Atul Mohan (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Mohan updated PARQUET-2185: Description: ParquetReader objects can be constructed using the builder as follows:   ParquetRea

[jira] [Created] (PARQUET-2185) ParquetReader constructed using builder fails to read encrypted files

2022-09-07 Thread Atul Mohan (Jira)
Atul Mohan created PARQUET-2185: --- Summary: ParquetReader constructed using builder fails to read encrypted files Key: PARQUET-2185 URL: https://issues.apache.org/jira/browse/PARQUET-2185 Project: Parque

[jira] [Resolved] (PARQUET-2178) ParquetReader constructed using builder fails to read encrypted files

2022-09-07 Thread Atul Mohan (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Mohan resolved PARQUET-2178. - Resolution: Duplicate > ParquetReader constructed using builder fails to read encrypted files >

[jira] [Commented] (PARQUET-758) [Format] HALF precision FLOAT Logical type

2022-09-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601269#comment-17601269 ] ASF GitHub Bot commented on PARQUET-758: pitrou commented on code in PR #184: UR

[GitHub] [parquet-format] pitrou commented on a diff in pull request #184: PARQUET-758: Add Float16/Half-float logical type

2022-09-07 Thread GitBox
pitrou commented on code in PR #184: URL: https://github.com/apache/parquet-format/pull/184#discussion_r964742903 ## src/main/thrift/parquet.thrift: ## @@ -232,6 +232,7 @@ struct MapType {} // see LogicalTypes.md struct ListType {}// see LogicalTypes.md struct EnumType

[jira] [Commented] (PARQUET-758) [Format] HALF precision FLOAT Logical type

2022-09-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601268#comment-17601268 ] ASF GitHub Bot commented on PARQUET-758: pitrou commented on PR #184: URL: https

[jira] [Updated] (PARQUET-2182) Handle unknown logical types

2022-09-07 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou updated PARQUET-2182: Component/s: parquet-mr > Handle unknown logical types > > >

[GitHub] [parquet-format] pitrou commented on pull request #184: PARQUET-758: Add Float16/Half-float logical type

2022-09-07 Thread GitBox
pitrou commented on PR #184: URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1239282706 I agree with @emkornfield that ordering issues seem largely orthogonal, as they also affect FLOAT32 and FLOAT64 types. -- This is an automated message from the Apache Git Service. T

[jira] [Commented] (PARQUET-758) [Format] HALF precision FLOAT Logical type

2022-09-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601267#comment-17601267 ] ASF GitHub Bot commented on PARQUET-758: pitrou commented on code in PR #184: UR

[GitHub] [parquet-format] pitrou commented on a diff in pull request #184: PARQUET-758: Add Float16/Half-float logical type

2022-09-07 Thread GitBox
pitrou commented on code in PR #184: URL: https://github.com/apache/parquet-format/pull/184#discussion_r964739579 ## src/main/thrift/parquet.thrift: ## @@ -232,6 +232,7 @@ struct MapType {} // see LogicalTypes.md struct ListType {}// see LogicalTypes.md struct EnumType

[jira] [Commented] (PARQUET-1332) [C++] Add bloom filter utility class

2022-09-07 Thread Xinyu Zeng (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601199#comment-17601199 ] Xinyu Zeng commented on PARQUET-1332: - [~junjie] It seems like there is no further