[jira] [Commented] (PARQUET-1222) Specify a well-defined sorting order for float and double types

[ https://issues.apache.org/jira/browse/PARQUET-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614581#comment-17614581 ] Micah Kornfield commented on PARQUET-1222: -- Elevating the specification level seems fine. I

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614580#comment-17614580 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on PR #995: URL:

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614579#comment-17614579 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on code in PR #995: URL:

[GitHub] [parquet-mr] emkornfield commented on pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on PR #995: URL: https://github.com/apache/parquet-mr/pull/995#issuecomment-1272447374 Mostly looks reasonable, I'm not too familiar with parquet-mr @shangxinli can you recommend someone who might be able to give a better review? -- This is an automated message from

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on code in PR #995: URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990727498 ## parquet-protobuf/src/test/resources/Trees.proto: ## @@ -0,0 +1,37 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614578#comment-17614578 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on code in PR #995: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on code in PR #995: URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990727282 ## parquet-protobuf/src/test/resources/BinaryTree.par: ## @@ -0,0 +1,50 @@ +message Trees.BinaryTree { + optional group value = 1 { Review Comment: or is par

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614576#comment-17614576 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on code in PR #995: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on code in PR #995: URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990727030 ## parquet-protobuf/src/test/resources/BinaryTree.par: ## @@ -0,0 +1,50 @@ +message Trees.BinaryTree { + optional group value = 1 { Review Comment: Aren't

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614573#comment-17614573 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on code in PR #995: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on code in PR #995: URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990726331 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoWriteSupport.java: ## @@ -559,7 +564,14 @@ final void writeRawValue(Object value) { class

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614572#comment-17614572 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on code in PR #995: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on code in PR #995: URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990726272 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoWriteSupport.java: ## @@ -559,7 +564,14 @@ final void writeRawValue(Object value) { class

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614570#comment-17614570 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on code in PR #995: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on code in PR #995: URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990726095 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java: ## @@ -99,9 +139,9 @@ private Type.Repetition getRepetition(FieldDescriptor

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614569#comment-17614569 ] ASF GitHub Bot commented on PARQUET-1711: - emkornfield commented on code in PR #995: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

emkornfield commented on code in PR #995: URL: https://github.com/apache/parquet-mr/pull/995#discussion_r990725805 ## parquet-protobuf/src/test/java/org/apache/parquet/proto/ProtoSchemaConverterTest.java: ## @@ -82,264 +93,447 @@ public void testConvertAllDatatypes() throws

[GitHub] [parquet-mr] danielcweeks commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

danielcweeks commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r990665831 ## parquet-common/src/main/java/org/apache/parquet/io/SeekableInputStream.java: ## @@ -23,6 +23,10 @@ import java.io.IOException; import java.io.InputStream;

Re: Vectored IO in Parquet ( https://issues.apache.org/jira/browse/PARQUET-2171)

Thanks, Mukund! As spoken at the conference, this is a great feature! Look forward to reviewing the changes! On Tue, Sep 27, 2022 at 9:29 AM Mukund Madhav Thakur wrote: > Hi Team, > We in hadoop project recently added a new feature in Hadoop Vectored IO > which will be released in the upcoming