[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619243#comment-17619243 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on PR #1000: URL:

[GitHub] [parquet-mr] emkornfield commented on pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-17 Thread GitBox
emkornfield commented on PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1281847541 FWIW, Arrow/Parquet C++ checkout https://github.com/apache/parquet-testing when running parquet tests (instead of checking binary files into the main repo). As an aside, I

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619192#comment-17619192 ] ASF GitHub Bot commented on PARQUET-2196: - shangxinli commented on PR #1000: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-17 Thread GitBox
shangxinli commented on PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1281720715 Hm... any opinion on this @ggershinsky ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619185#comment-17619185 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-17 Thread GitBox
wgtmac commented on PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1281706700 > Looks good. The only thing is we checked in binary files directly. It would be hard to maintain in the future. Can you generate the parquet file using the parquetwriter?

[GitHub] [parquet-mr] mukund-thakur commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-17 Thread GitBox
mukund-thakur commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r997562516 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-17 Thread GitBox
parthchandra commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r997548363 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-17 Thread GitBox
parthchandra commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r997548363 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[jira] [Commented] (PARQUET-2042) Unwrap common Protobuf wrappers and logical Timestamps, Date, TimeOfDay

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619125#comment-17619125 ] ASF GitHub Bot commented on PARQUET-2042: - sheinbergon commented on PR #900: URL:

[GitHub] [parquet-mr] sheinbergon commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-10-17 Thread GitBox
sheinbergon commented on PR #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-1281551940 @shangxinli any reason why this PR hasn't been merged yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-17 Thread GitBox
parthchandra commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r997546366 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] mukund-thakur commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-17 Thread GitBox
mukund-thakur commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r997539131 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-17 Thread GitBox
parthchandra commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r997390810 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619038#comment-17619038 ] ASF GitHub Bot commented on PARQUET-2196: - shangxinli commented on PR #1000: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-17 Thread GitBox
shangxinli commented on PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1281244709 Looks good. The only thing is we checked in binary files directly. It would be hard to maintain in the future. Can you generate the parquet file using the parquetwriter? --

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619032#comment-17619032 ] ASF GitHub Bot commented on PARQUET-1711: - shangxinli commented on PR #995: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

2022-10-17 Thread GitBox
shangxinli commented on PR #995: URL: https://github.com/apache/parquet-mr/pull/995#issuecomment-1281237456 @ggershinsky Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619025#comment-17619025 ] ASF GitHub Bot commented on PARQUET-1711: - jinyius commented on PR #995: URL:

[GitHub] [parquet-mr] jinyius commented on pull request #995: PARQUET-1711: support recursive proto schemas by limiting recursion depth

2022-10-17 Thread GitBox
jinyius commented on PR #995: URL: https://github.com/apache/parquet-mr/pull/995#issuecomment-1281213675 > Mostly looks reasonable, I'm not too familiar with parquet-mr @shangxinli can you recommend someone who might be able to give a better review? pinging @shangxinli :) -- This

[jira] [Commented] (PARQUET-2161) Row positions are computed incorrectly when range or offset metadata filter is used

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619007#comment-17619007 ] ASF GitHub Bot commented on PARQUET-2161: - shangxinli commented on PR #978: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #978: PARQUET-2161: Fix row index generation in combination with range filtering

2022-10-17 Thread GitBox
shangxinli commented on PR #978: URL: https://github.com/apache/parquet-mr/pull/978#issuecomment-1281184662 @ala Thanks for pinging me! At this moment, I don't have ETA yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-17 Thread GitBox
parthchandra commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r997314660 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[jira] [Commented] (PARQUET-2161) Row positions are computed incorrectly when range or offset metadata filter is used

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618960#comment-17618960 ] ASF GitHub Bot commented on PARQUET-2161: - ala commented on PR #978: URL:

[GitHub] [parquet-mr] ala commented on pull request #978: PARQUET-2161: Fix row index generation in combination with range filtering

2022-10-17 Thread GitBox
ala commented on PR #978: URL: https://github.com/apache/parquet-mr/pull/978#issuecomment-1281067651 @ggershinsky @shangxinli Hi! I just wanted to ask if 1.12.4 release might be happening soon (it seems in the previous years there usually was a release around September-October time)? We