[GitHub] [parquet-mr] shangxinli commented on pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on PR #960: URL: https://github.com/apache/parquet-mr/pull/960#issuecomment-1336239074 @theosib-amazon Thanks again for your contribution! I see the comments are generally around duplicating code, refactoring, and making code maintainable. If you have a measurement of

[jira] [Commented] (PARQUET-2208) Add details to nested column encryption config doc and exception text

[ https://issues.apache.org/jira/browse/PARQUET-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642899#comment-17642899 ] ASF GitHub Bot commented on PARQUET-2208: - shangxinli merged PR #1009: URL:

[GitHub] [parquet-mr] shangxinli merged pull request #1009: PARQUET-2208: Add details to nested column encryption config doc and exception text

shangxinli merged PR #1009: URL: https://github.com/apache/parquet-mr/pull/1009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PARQUET-2212) Add ByteBuffer api for decryptors to allow direct memory to be decrypted

[ https://issues.apache.org/jira/browse/PARQUET-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642898#comment-17642898 ] ASF GitHub Bot commented on PARQUET-2212: - shangxinli commented on code in PR #1008: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1008: PARQUET-2212: Add ByteBuffer api for decryptors to allow direct memory to be decrypted

shangxinli commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1038821325 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java: ## @@ -133,11 +135,36 @@ public DataPage readPage() { public

[jira] [Commented] (PARQUET-2212) Add ByteBuffer api for decryptors to allow direct memory to be decrypted

[ https://issues.apache.org/jira/browse/PARQUET-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642894#comment-17642894 ] ASF GitHub Bot commented on PARQUET-2212: - shangxinli commented on code in PR #1008: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1008: PARQUET-2212: Add ByteBuffer api for decryptors to allow direct memory to be decrypted

shangxinli commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1038820534 ## parquet-hadoop/src/main/java/org/apache/parquet/ParquetReadOptions.java: ## @@ -44,6 +44,8 @@ public class ParquetReadOptions { private static final int

[jira] [Commented] (PARQUET-2198) Vulnerabilities in jackson-databind

[ https://issues.apache.org/jira/browse/PARQUET-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642892#comment-17642892 ] ASF GitHub Bot commented on PARQUET-2198: - shangxinli merged PR #1005: URL:

[GitHub] [parquet-mr] shangxinli merged pull request #1005: PARQUET-2198 : Updating jackson data bind version to fix CVEs

shangxinli merged PR #1005: URL: https://github.com/apache/parquet-mr/pull/1005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PARQUET-2184) Improve SnappyCompressor buffer expansion performance

[ https://issues.apache.org/jira/browse/PARQUET-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642891#comment-17642891 ] ASF GitHub Bot commented on PARQUET-2184: - shangxinli commented on PR #993: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #993: PARQUET-2184: Improve the allocation behavior of SnappyCompressor

shangxinli commented on PR #993: URL: https://github.com/apache/parquet-mr/pull/993#issuecomment-1336215536 @abaranec can you resolve the conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PARQUET-2177) Fix parquet-cli not to fail showing descriptions

[ https://issues.apache.org/jira/browse/PARQUET-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642889#comment-17642889 ] ASF GitHub Bot commented on PARQUET-2177: - shangxinli merged PR #991: URL:

[GitHub] [parquet-mr] shangxinli merged pull request #991: PARQUET-2177: Fix parquet-cli not to fail showing descriptions

shangxinli merged PR #991: URL: https://github.com/apache/parquet-mr/pull/991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642888#comment-17642888 ] ASF GitHub Bot commented on PARQUET-1711: - shangxinli closed pull request #988: PARQUET-1711:

[GitHub] [parquet-mr] shangxinli closed pull request #988: PARQUET-1711: Break circular dependencies in proto definitions

shangxinli closed pull request #988: PARQUET-1711: Break circular dependencies in proto definitions URL: https://github.com/apache/parquet-mr/pull/988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PARQUET-1711) [parquet-protobuf] stack overflow when work with well known json type

[ https://issues.apache.org/jira/browse/PARQUET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642887#comment-17642887 ] ASF GitHub Bot commented on PARQUET-1711: - shangxinli commented on PR #988: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #988: PARQUET-1711: Break circular dependencies in proto definitions

shangxinli commented on PR #988: URL: https://github.com/apache/parquet-mr/pull/988#issuecomment-1336214908 Since https://github.com/apache/parquet-mr/pull/995 is merged, let's close this one. Thanks @matthieun for the contribution ! -- This is an automated message from the Apache Git

[jira] [Commented] (PARQUET-2173) Fix parquet build against hadoop 3.3.3+

[ https://issues.apache.org/jira/browse/PARQUET-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642886#comment-17642886 ] ASF GitHub Bot commented on PARQUET-2173: - shangxinli commented on PR #985: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #985: PARQUET-2173. Fix parquet build against hadoop 3.3.3+

shangxinli commented on PR #985: URL: https://github.com/apache/parquet-mr/pull/985#issuecomment-1336214427 cc @ggershinsky @wgtmac let me know if you have concern to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (PARQUET-2159) Parquet bit-packing de/encode optimization

[ https://issues.apache.org/jira/browse/PARQUET-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642884#comment-17642884 ] ASF GitHub Bot commented on PARQUET-2159: - shangxinli commented on PR #1011: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #1011: PARQUET-2159: java17 vector parquet bit-packing decode optimization

shangxinli commented on PR #1011: URL: https://github.com/apache/parquet-mr/pull/1011#issuecomment-1336210632 Thank @gszadovszky a lot for helping with this PR! +1 for what @gszadovszky said. The mainstream runtime JDK is still 1.8. Parquet is one of the underlying building blocks

[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642878#comment-17642878 ] ASF GitHub Bot commented on PARQUET-2149: - shangxinli commented on PR #968: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

shangxinli commented on PR #968: URL: https://github.com/apache/parquet-mr/pull/968#issuecomment-1336203668 @kazuyukitanimura @steveloughran @kbendick @ggershinsky @wgtmac @theosib-amazon Do you still have comments? -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642875#comment-17642875 ] ASF GitHub Bot commented on PARQUET-2149: - shangxinli commented on code in PR #968: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

shangxinli commented on code in PR #968: URL: https://github.com/apache/parquet-mr/pull/968#discussion_r1038808056 ## parquet-common/src/main/java/org/apache/parquet/bytes/AsyncMultiBufferInputStream.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642873#comment-17642873 ] ASF GitHub Bot commented on PARQUET-2149: - shangxinli commented on code in PR #968: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

shangxinli commented on code in PR #968: URL: https://github.com/apache/parquet-mr/pull/968#discussion_r1038807754 ## parquet-common/src/main/java/org/apache/parquet/bytes/AsyncMultiBufferInputStream.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642872#comment-17642872 ] ASF GitHub Bot commented on PARQUET-2149: - shangxinli commented on code in PR #968: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

shangxinli commented on code in PR #968: URL: https://github.com/apache/parquet-mr/pull/968#discussion_r1038807754 ## parquet-common/src/main/java/org/apache/parquet/bytes/AsyncMultiBufferInputStream.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation