gszadovszky commented on a change in pull request #870:
URL: https://github.com/apache/parquet-mr/pull/870#discussion_r578513538
##########
File path:
parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestStatistics.java
##########
@@ -479,6 +479,7 @@ public void test() throws IOException {
while ((pageReadStore = reader.readNextRowGroup()) != null) {
validator.validate(metadata.getFileMetaData().getSchema(),
pageReadStore);
}
+ reader.close();
Review comment:
I would suggest using try-with-resources to ensure reader is always
closed
##########
File path:
parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestParquetToThriftReadWriteAndProjection.java
##########
@@ -377,9 +377,9 @@ private void
shouldDoProjectionWithThriftColumnFilter(String filterDesc, TBase t
readValue = reader.getCurrentValue();
LOG.info("{}", readValue);
}
+ reader.close();
Review comment:
Same as above
##########
File path:
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestInputFormat.java
##########
@@ -398,7 +399,10 @@ public void testGetFootersReturnsInPredictableOrder()
throws IOException {
if (i > 0) {
url.append(',');
}
- url.append("file:").append(file.getAbsolutePath());
+ if (!SystemUtils.IS_OS_WINDOWS) {
+ url.append("file:");
+ }
+ url.append(file.getAbsolutePath());
Review comment:
I don't have any experience running Hadoop on Windows but I am not sure
this is the good approach to pass the tests. I think it would be better to
expect the same configuration on the different systems and handle OS relevant
paths in the production code if required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
