[GitHub] [parquet-mr] jianchun commented on a diff in pull request #1022: PARQUET-831: fix estimate page size check overflow corrupting parquet

2023-02-24 Thread via GitHub
jianchun commented on code in PR #1022: URL: https://github.com/apache/parquet-mr/pull/1022#discussion_r1117803552 ## parquet-column/src/test/java/org/apache/parquet/column/impl/TestColumnWriterV1.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [parquet-mr] jianchun commented on a diff in pull request #1022: PARQUET-831: fix estimate page size check overflow corrupting parquet

2023-02-23 Thread via GitHub
jianchun commented on code in PR #1022: URL: https://github.com/apache/parquet-mr/pull/1022#discussion_r1116058380 ## parquet-column/src/test/java/org/apache/parquet/column/impl/TestColumnWriterV1.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [parquet-mr] jianchun commented on a diff in pull request #1022: PARQUET-831: fix estimate page size check overflow corrupting parquet

2023-02-06 Thread via GitHub
jianchun commented on code in PR #1022: URL: https://github.com/apache/parquet-mr/pull/1022#discussion_r1097699497 ## parquet-column/src/test/java/org/apache/parquet/column/impl/TestColumnWriterV1.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [parquet-mr] jianchun commented on a diff in pull request #1022: PARQUET-831: fix estimate page size check overflow corrupting parquet

2023-02-06 Thread via GitHub
jianchun commented on code in PR #1022: URL: https://github.com/apache/parquet-mr/pull/1022#discussion_r1097699497 ## parquet-column/src/test/java/org/apache/parquet/column/impl/TestColumnWriterV1.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation