[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #1008: PARQUET-2212: Add ByteBuffer api for decryptors to allow direct memory to be decrypted

2023-01-13 Thread GitBox
parthchandra commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1069182893 ## parquet-format-structures/src/main/java/org/apache/parquet/format/BlockCipher.java: ## @@ -51,17 +52,26 @@ * @param AAD - Additional Authenticated

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #1008: PARQUET-2212: Add ByteBuffer api for decryptors to allow direct memory to be decrypted

2022-12-05 Thread GitBox
parthchandra commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1039958501 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java: ## @@ -133,11 +135,36 @@ public DataPage readPage() { public

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #1008: PARQUET-2212: Add ByteBuffer api for decryptors to allow direct memory to be decrypted

2022-11-15 Thread GitBox
parthchandra commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1023355113 ## parquet-hadoop/src/main/java/org/apache/parquet/ParquetReadOptions.java: ## @@ -44,6 +46,9 @@ public class ParquetReadOptions { private static final int

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #1008: PARQUET-2212: Add ByteBuffer api for decryptors to allow direct memory to be decrypted

2022-11-14 Thread GitBox
parthchandra commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1021927002 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java: ## @@ -133,11 +135,33 @@ public DataPage readPage() { public