[GitHub] [parquet-mr] shangxinli commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
shangxinli commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1193383006 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
shangxinli commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1172924045 @7c00 and @steveloughran Thank both of you for the great contribution! This PR comes from two authors. Can @7c00 add @steveloughran as the co-author to this PR? [This](https://github.blog/2018-01-29-commit-together-with-co-authors/) is an example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
shangxinli commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1151315837 > I've taken this PR and added the changes I was suggesting, plus tests. see #971. If you take that extra commit and merge it in here, it should complete this PR @7c00 Are you OK since you are originally created this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
shangxinli commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1123901314 @7c00 Do you have time to look into the last feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap
shangxinli commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1086966074 Thanks for adding the check and debug log. LGTM! One more thing(sorry for not asking at first-round review), do you think it makes sense to add tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
