[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0
steveloughran commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r905967944 ## pom.xml: ## @@ -76,7 +76,7 @@ 2.13.2.2 0.14.2 shaded.parquet -2.10.1 +3.2.0 Review Comment: I was being unambitious. move to this, the oldest 3.x release working on java11 ensures that anything else on a version >= to this should link properly. if you do want to be more current, well, spark is on 3.3.3, hive is trying to move to 3.3.x and I will be doing a 3.3.4 release in a week's time, which is just some security changes mostly of relevance to servers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0
steveloughran commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r905965620 ## parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java: ## @@ -20,8 +20,8 @@ import org.apache.hadoop.fs.GlobPattern; -import java.util.regex.Pattern; -import java.util.regex.PatternSyntaxException; +import com.google.re2j.Pattern; Review Comment: +1 for cutting. i will update the patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
