[GitHub] [parquet-mr] sunchao commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0
sunchao commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900689594 ## parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java: ## @@ -20,8 +20,8 @@ import org.apache.hadoop.fs.GlobPattern; -import java.util.regex.Pattern; -import java.util.regex.PatternSyntaxException; +import com.google.re2j.Pattern; Review Comment: I think this may not work for projects like Spark who are using Hadoop shaded client, since the `GlobPattern.compiled` is relocated to `org.apache.hadoop.shaded.com.google.re2j.Pattern`. It might be easier to just remove the class as it has been marked as deprecated since Parquet 1.8.0, 2015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] sunchao commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0
sunchao commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900689594 ## parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java: ## @@ -20,8 +20,8 @@ import org.apache.hadoop.fs.GlobPattern; -import java.util.regex.Pattern; -import java.util.regex.PatternSyntaxException; +import com.google.re2j.Pattern; Review Comment: I think this may not work for projects like Spark who are using Hadoop shaded client, since the `GlobPattern.compiled` is relocated to `org.apache.hadoop.shaded.com.google.re2j.Pattern`. It might be easier to just remove the class as it has been marked as deprecated since Parquet 1.8.0, 2015. It is also not used anywhere in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] sunchao commented on a diff in pull request #976: PARQUET-2158: Upgrade Hadoop dependency to version 3.2.0
sunchao commented on code in PR #976: URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900576817 ## pom.xml: ## @@ -76,7 +76,7 @@ 2.13.2.2 0.14.2 shaded.parquet -2.10.1 +3.2.0 Review Comment: hmm why 3.2.0, not 3.3.1/3.3.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
