Ryan Blue created PARQUET-332:
---------------------------------

             Summary: Incompatible changes in o.a.p.thrift.projection
                 Key: PARQUET-332
                 URL: https://issues.apache.org/jira/browse/PARQUET-332
             Project: Parquet
          Issue Type: Bug
          Components: parquet-mr
            Reporter: Ryan Blue
             Fix For: 1.8.0


There are incompatible changes in o.a.p.thrift.projection that weren't caught 
because of PARQUET-330:
* The return type of [{{FieldsPath#push(ThriftField)}} 
changed|https://github.com/apache/parquet-mr/commit/ded56ffd598e41e32817f6c1b091595fe7122e8b#diff-e990fead0bb1a6faa5080efba86bc81fL34]
 ([return type compatibility 
ref|https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.15])
* [{{FieldProjectionFilter}} changed to an 
interface|https://github.com/apache/parquet-mr/commit/7fc7998398373a14b4cdc0ce18abdeb221b1ccf9#diff-49628343f8d6daf6cb774b6c6ccab82cL29]

Both of these are incompatibilities if {{FieldProjectionFilter}} is part of the 
public API, which it appears to be because it is used by the ScroogeReadSupport 
and the ThriftSchemaConverter (public constructor).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to