[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308379#comment-17308379 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888051 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308380#comment-17308380 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888052 from

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308350#comment-17308350 ] ASF subversion and git services commented on PDFBOX-2602: - Commit 1888050 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308337#comment-17308337 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888047 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308336#comment-17308336 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888046 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308335#comment-17308335 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888045 from

Re: Redaction Annotation

2021-03-24 Thread Tilman Hausherr
Am 24.03.2021 um 20:22 schrieb Kett, Bernward: Hi Tilmann, it's the base class, appearances some other adjustments in lower classes (especially for data streams). I also created a sample main class for demo (reused your appearance example). I also detected that it's preferable to create the

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2021-03-24 Thread GitBox
valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-806093557 > labels.length is always > 0 because there's always at least 1 page in a document. If not, there's something rotten anyway. I got a little carried away by the debugger.

RE: Redaction Annotation

2021-03-24 Thread Kett, Bernward
Hi Tilmann, it's the base class, appearances some other adjustments in lower classes (especially for data streams). I also created a sample main class for demo (reused your appearance example). I also detected that it's preferable to create the Normal appearance after the Rollover appearance.

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308121#comment-17308121 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888033 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308120#comment-17308120 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888032 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308117#comment-17308117 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888030 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308118#comment-17308118 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888031 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308113#comment-17308113 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888029 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308112#comment-17308112 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888028 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308109#comment-17308109 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888027 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308108#comment-17308108 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888026 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308099#comment-17308099 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888025 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308098#comment-17308098 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888024 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308096#comment-17308096 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888022 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308097#comment-17308097 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1888023 from

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2021-03-24 Thread GitBox
THausherr commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-806055173 labels.length is always > 0 because there's always at least 1 page in a document. If not, there's something rotten anyway. -- This is an automated message from the Apache Git

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

2021-03-24 Thread GitBox
THausherr commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-806051549 Thanks, I've forwarded the test thing and changed the JIRA issue. Re PDFDebugger, I'll do just a few of the changes. (I'm hopelessly behind) I'll do the "static" thing

[jira] [Commented] (PDFBOX-4669) Ensure proper functionality of COSArrayList

2021-03-24 Thread Tilman Hausherr (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308086#comment-17308086 ] Tilman Hausherr commented on PDFBOX-4669: -

[jira] [Updated] (PDFBOX-2941) Improve PDFDebugger (2)

2021-03-24 Thread Tilman Hausherr (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilman Hausherr updated PDFBOX-2941: Description: This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came

[jira] [Updated] (PDFBOX-2941) Improve PDFDebugger (2)

2021-03-24 Thread Tilman Hausherr (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilman Hausherr updated PDFBOX-2941: Description: This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came

[jira] [Commented] (PDFBOX-5139) Signing PDF with empty fields multiple times breaks signature

2021-03-24 Thread Tilman Hausherr (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307997#comment-17307997 ] Tilman Hausherr commented on PDFBOX-5139: - I tried only 1.5 and signed with CreateSignature

Re: Redaction Annotation

2021-03-24 Thread Tilman Hausherr
Yes... depending on the size / complexity a signed ICLA might be needed. Is this just the PD class or also appearances? Please upload your attachments on a sharehoster, all attachments here were deleted. Tilman Am 23.03.2021 um 21:00 schrieb Kett, Bernward: Hi all, I successfully

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2021-03-24 Thread GitBox
valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-805890260 In https://issues.apache.org/jira/browse/PDFBOX-2941?filter=allopenissues is written "show page labels additional to page number (see file from TIKA-2121 as example)". The

[GitHub] [pdfbox] valerybokov commented on pull request #107: potential memory leaks and small performance improvements

2021-03-24 Thread GitBox
valerybokov commented on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-805885019 when I uncommented COSArrayListTest.addToList and launched it, it was green -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (PDFBOX-5139) Signing PDF with empty fields multiple times breaks signature

2021-03-24 Thread Fabricio (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabricio updated PDFBOX-5139: - Description: Hi! I apologize if there is already a similar report. We have a PDF document with

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307620#comment-17307620 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1887992 from

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307619#comment-17307619 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1887991 from

[jira] [Commented] (PDFBOX-5138) Embedded files not extracted from PDF files with multilevel EmbeddedFiles tree

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PDFBOX-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307612#comment-17307612 ] ASF subversion and git services commented on PDFBOX-5138: - Commit 1887990 from