[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-26 Thread Lonzak (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062664#comment-16062664 ] Lonzak commented on PDFBOX-3820: yes looking good! (Good that you adapted the patch for the

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-24 Thread Tilman Hausherr (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061976#comment-16061976 ] Tilman Hausherr commented on PDFBOX-3820: - [~tom_1st] Please confirm that the modified commit is

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061936#comment-16061936 ] ASF subversion and git services commented on PDFBOX-3820: - Commit 1799765 from

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061937#comment-16061937 ] ASF subversion and git services commented on PDFBOX-3820: - Commit 1799766 from

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-24 Thread Tilman Hausherr (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061930#comment-16061930 ] Tilman Hausherr commented on PDFBOX-3820: - I've removed the unused constructor, so now we have

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061929#comment-16061929 ] ASF subversion and git services commented on PDFBOX-3820: - Commit 1799764 from

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061928#comment-16061928 ] ASF subversion and git services commented on PDFBOX-3820: - Commit 1799763 from

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-23 Thread Lonzak (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060723#comment-16060723 ] Lonzak commented on PDFBOX-3820: If you got further questions don't hesitate to ask - it would be cool if

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-19 Thread Lonzak (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054647#comment-16054647 ] Lonzak commented on PDFBOX-3820: You are right again - since the rotation is always 0 the call can be

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-19 Thread Tilman Hausherr (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054341#comment-16054341 ] Tilman Hausherr commented on PDFBOX-3820: - Your pageless setVisibleSignDesigner() methods call

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-19 Thread Lonzak (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053534#comment-16053534 ] Lonzak commented on PDFBOX-3820: Ups uploaded the wrong files. Now everything should be as expected... >

[jira] [Commented] (PDFBOX-3820) [Patch] Improved signing of existing signature fields II

2017-06-16 Thread Tilman Hausherr (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052071#comment-16052071 ] Tilman Hausherr commented on PDFBOX-3820: - I looked at the patches and the parts with "+" are