[jira] [Commented] (PDFBOX-2963) Remove Bouncy Castle Reference

2016-11-19 Thread David Hook (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679957#comment-15679957
 ] 

David Hook commented on PDFBOX-2963:


It should be safe to remove the setProvider("BC"). The implications of doing 
that are that the class will use the JVM's provider precedence for resolving 
the algorithm required for unwrapping the secret key.

> Remove Bouncy Castle Reference
> --
>
> Key: PDFBOX-2963
> URL: https://issues.apache.org/jira/browse/PDFBOX-2963
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Crypto, PDModel
>Affects Versions: 1.8.9, 1.8.10, 2.0.0
>Reporter: Johnny Minty
>
> PDFBox Versions 1.8.X and 2.0.X add Bouncy Castle as a security provider 
> explicitly (Hard coded)
> Referencing bouncy castle explicitly ties PDF box to a specific provider 
> implementation.
> Instead of referencing BouncyCastleProvider explicitly provide an option to 
> select another provider or alternatively allow a way to override the default. 
> Version 1.8.X:
> https://github.com/apache/pdfbox/blob/1.8.10/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlersManager.java
> {code}
> public static SecurityHandlersManager getInstance()
> {
> if(instance == null)
> {
> instance = new SecurityHandlersManager();
> Security.addProvider(new BouncyCastleProvider());
> }
> return instance;
> }
> {code}
> Version 2.0.0:
> https://github.com/apache/pdfbox/blob/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/SecurityHandlerFactory.java
> {code}
>static
> {
> Security.addProvider(new BouncyCastleProvider());
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-2852) Improve code quality (2)

2016-11-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679774#comment-15679774
 ] 

ASF subversion and git services commented on PDFBOX-2852:
-

Commit 1770511 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1770511 ]

PDFBOX-2852: fix typo

> Improve code quality (2)
> 
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
> Attachments: PDNameTreeNode.java.patch, StringBuffer.patch, 
> XMPSchema.java.patch, explicit_array_creation.patch, fix_javadoc.patch, 
> foreach.patch, foreach2.patch, generic_type_arguments.patch, noarray.patch, 
> semicolon.patch, stringbuilder.patch, unnecessary_type_casting.patch, 
> unused_imports.patch, usestatic.patch, winansiencoding.patch, 
> winansiencoding2.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-2852) Improve code quality (2)

2016-11-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679773#comment-15679773
 ] 

ASF subversion and git services commented on PDFBOX-2852:
-

Commit 1770510 from [~tilman] in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1770510 ]

PDFBOX-2852: fix typo

> Improve code quality (2)
> 
>
> Key: PDFBOX-2852
> URL: https://issues.apache.org/jira/browse/PDFBOX-2852
> Project: PDFBox
>  Issue Type: Task
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
> Attachments: PDNameTreeNode.java.patch, StringBuffer.patch, 
> XMPSchema.java.patch, explicit_array_creation.patch, fix_javadoc.patch, 
> foreach.patch, foreach2.patch, generic_type_arguments.patch, noarray.patch, 
> semicolon.patch, stringbuilder.patch, unnecessary_type_casting.patch, 
> unused_imports.patch, usestatic.patch, winansiencoding.patch, 
> winansiencoding2.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-3584) Build and test PDFBox with JDK9

2016-11-19 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679755#comment-15679755
 ] 

Tilman Hausherr commented on PDFBOX-3584:
-

Changes needed in pom.xml files:

preflight pom:
{code}
--Xmx768m -add-modules java.activation --add-modules 
java.xml.bind
{code}


xmpbox pom:
{code}

maven-surefire-plugin

-add-modules java.xml.bind


{code}


> Build and test PDFBox with JDK9
> ---
>
> Key: PDFBOX-3584
> URL: https://issues.apache.org/jira/browse/PDFBOX-3584
> Project: PDFBox
>  Issue Type: Task
>Reporter: Tilman Hausherr
>  Labels: jdk9
>
> Issue to collect problems and solutions for building and testing PDFBox with 
> JDK9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Created] (PDFBOX-3584) Build and test PDFBox with JDK9

2016-11-19 Thread Tilman Hausherr (JIRA)
Tilman Hausherr created PDFBOX-3584:
---

 Summary: Build and test PDFBox with JDK9
 Key: PDFBOX-3584
 URL: https://issues.apache.org/jira/browse/PDFBOX-3584
 Project: PDFBox
  Issue Type: Task
Reporter: Tilman Hausherr


Issue to collect problems and solutions for building and testing PDFBox with 
JDK9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Updated] (PDFBOX-3584) Build and test PDFBox with JDK9

2016-11-19 Thread Tilman Hausherr (JIRA)

 [ 
https://issues.apache.org/jira/browse/PDFBOX-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-3584:

Labels: jdk9  (was: )

> Build and test PDFBox with JDK9
> ---
>
> Key: PDFBOX-3584
> URL: https://issues.apache.org/jira/browse/PDFBOX-3584
> Project: PDFBox
>  Issue Type: Task
>Reporter: Tilman Hausherr
>  Labels: jdk9
>
> Issue to collect problems and solutions for building and testing PDFBox with 
> JDK9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Issue Comment Deleted] (PDFBOX-3581) PDFTextStripper not working with multiple threads

2016-11-19 Thread Tilman Hausherr (JIRA)

 [ 
https://issues.apache.org/jira/browse/PDFBOX-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-3581:

Comment: was deleted

(was: hint: you can include code like this 

\{code\}
your code lines
\{code\}   

(without the blackslashes), that will look nicer in a browser. You can also 
edit your past comments if you want :-))

> PDFTextStripper not working with multiple threads
> -
>
> Key: PDFBOX-3581
> URL: https://issues.apache.org/jira/browse/PDFBOX-3581
> Project: PDFBox
>  Issue Type: Bug
>  Components: Text extraction
>Affects Versions: 2.0.3
> Environment: Ubuntu 15.1
>Reporter: Dmitri Russu
>  Labels: multithreading
>
> Hi, I try to use pdfbox to extract text from a list of files, the problem is 
> PDFTextStripper does not work on thread mode, when I try to use it in 
> multythread nothing happens. it is a bug or limitation? 
> could you help me ?
>  thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-3581) PDFTextStripper not working with multiple threads

2016-11-19 Thread Tilman Hausherr (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679408#comment-15679408
 ] 

Tilman Hausherr commented on PDFBOX-3581:
-

Please don't set the fix version at this time. We do this when we know that 
there is something that can be fixed, and that we intend to fix it for that 
version. At this time, it isn't even sure that it is a bug at all.

> PDFTextStripper not working with multiple threads
> -
>
> Key: PDFBOX-3581
> URL: https://issues.apache.org/jira/browse/PDFBOX-3581
> Project: PDFBox
>  Issue Type: Bug
>  Components: Text extraction
>Affects Versions: 2.0.3
> Environment: Ubuntu 15.1
>Reporter: Dmitri Russu
>  Labels: multithreading
>
> Hi, I try to use pdfbox to extract text from a list of files, the problem is 
> PDFTextStripper does not work on thread mode, when I try to use it in 
> multythread nothing happens. it is a bug or limitation? 
> could you help me ?
>  thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Updated] (PDFBOX-3581) PDFTextStripper not working with multiple threads

2016-11-19 Thread Tilman Hausherr (JIRA)

 [ 
https://issues.apache.org/jira/browse/PDFBOX-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-3581:

Fix Version/s: (was: 2.0.4)

> PDFTextStripper not working with multiple threads
> -
>
> Key: PDFBOX-3581
> URL: https://issues.apache.org/jira/browse/PDFBOX-3581
> Project: PDFBox
>  Issue Type: Bug
>  Components: Text extraction
>Affects Versions: 2.0.3
> Environment: Ubuntu 15.1
>Reporter: Dmitri Russu
>  Labels: multithreading
>
> Hi, I try to use pdfbox to extract text from a list of files, the problem is 
> PDFTextStripper does not work on thread mode, when I try to use it in 
> multythread nothing happens. it is a bug or limitation? 
> could you help me ?
>  thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Updated] (PDFBOX-3581) PDFTextStripper not working with multiple threads

2016-11-19 Thread Dmitri Russu (JIRA)

 [ 
https://issues.apache.org/jira/browse/PDFBOX-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitri Russu updated PDFBOX-3581:
-
Fix Version/s: 2.0.4

> PDFTextStripper not working with multiple threads
> -
>
> Key: PDFBOX-3581
> URL: https://issues.apache.org/jira/browse/PDFBOX-3581
> Project: PDFBox
>  Issue Type: Bug
>  Components: Text extraction
>Affects Versions: 2.0.3
> Environment: Ubuntu 15.1
>Reporter: Dmitri Russu
>  Labels: multithreading
> Fix For: 2.0.4
>
>
> Hi, I try to use pdfbox to extract text from a list of files, the problem is 
> PDFTextStripper does not work on thread mode, when I try to use it in 
> multythread nothing happens. it is a bug or limitation? 
> could you help me ?
>  thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Comment Edited] (PDFBOX-3581) PDFTextStripper not working with multiple threads

2016-11-19 Thread Dmitri Russu (JIRA)

[ 
https://issues.apache.org/jira/browse/PDFBOX-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677133#comment-15677133
 ] 

Dmitri Russu edited comment on PDFBOX-3581 at 11/19/16 2:57 PM:


no Exception, and it is stopping working when arrive on PDFTextStripper 
pDFTextStripper = new PDFTextStripper();
{code}
 private void scanFolderFiles(File scanDirectory) {
File[] filesScan = scanDirectory.listFiles();

if ( filesScan.length > 0 ) {
int iterator=0;
for (final File fileEntry : filesScan) {

   
if (fileEntry.isDirectory()) {
scanFolderFiles(fileEntry);
} else {
try {
   new PDFExtractThread(fileEntry).start();
}
catch (Exception e) {
e.printStackTrace();
}
}

iterator++;
}
}
}




 Method used for text extracting

  public void pdfBoxExtractText() throws Exception {
//Retrieving text from PDF document
PDFTextStripper pdfStripper = new PDFTextStripper();
System.out.println(this.fileName);
FileWriter fileWriter = new FileWriter(this.fileName+".txt");
BufferedWriter writer = new BufferedWriter(fileWriter);
String text = pdfStripper.getText(this.document);

System.out.println(text);

writer.write(text);
writer.close();
}

{code}



was (Author: dmitri_russu):
no Exception, and it is stopping working when arrive on PDFTextStripper 
pDFTextStripper = new PDFTextStripper();

 private void scanFolderFiles(File scanDirectory) {
File[] filesScan = scanDirectory.listFiles();

if ( filesScan.length > 0 ) {
int iterator=0;
for (final File fileEntry : filesScan) {

   
if (fileEntry.isDirectory()) {
scanFolderFiles(fileEntry);
} else {
try {
   new PDFExtractThread(fileEntry).start();
}
catch (Exception e) {
e.printStackTrace();
}
}

iterator++;
}
}
}




 Method used for text extracting

  public void pdfBoxExtractText() throws Exception {
//Retrieving text from PDF document
PDFTextStripper pdfStripper = new PDFTextStripper();
System.out.println(this.fileName);
FileWriter fileWriter = new FileWriter(this.fileName+".txt");
BufferedWriter writer = new BufferedWriter(fileWriter);
String text = pdfStripper.getText(this.document);

System.out.println(text);

writer.write(text);
writer.close();
}




> PDFTextStripper not working with multiple threads
> -
>
> Key: PDFBOX-3581
> URL: https://issues.apache.org/jira/browse/PDFBOX-3581
> Project: PDFBox
>  Issue Type: Bug
>  Components: Text extraction
>Affects Versions: 2.0.3
> Environment: Ubuntu 15.1
>Reporter: Dmitri Russu
>  Labels: multithreading
>
> Hi, I try to use pdfbox to extract text from a list of files, the problem is 
> PDFTextStripper does not work on thread mode, when I try to use it in 
> multythread nothing happens. it is a bug or limitation? 
> could you help me ?
>  thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org