[jira] [Comment Edited] (PDFBOX-5134) Very slow rendering on PageDrawer.shadingFill
[
https://issues.apache.org/jira/browse/PDFBOX-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303733#comment-17303733
]
Oliver Schmidtmer edited comment on PDFBOX-5134 at 3/17/21, 9:28 PM:
-
That is correct, the slow painting is Java itself. However, the clipping area
is null and the paint applied to the whole image while those shades are
PDTriangleBasedShadingTypes which only cover a very small area.
For example with the device bounds [x=0,y=0,width=4031,height=2024] a bounding
rectangle, calculated in GouraudShadingContext.setTriangleList, around the
triangles for shading COSName\{Sh0} is only
[x=2916.300048828125,y=897.4940185546875,w=16.97998046875,h=17.0400390625]
Applying a Paint to such a small area should be much faster. I probably need
more time to look into how to calculate that beforehand and setting the
clipping area.
I'm sorry I hadn't already analyzed it that deeply a few hours ago. I only
suspected there should be some way to set a better clipping area for a such
small painted area. :)
was (Author: schmidor):
That is correct, the slow painting is Java itself. However, the clipping area
is null and the paint applied to the whole image while those shades are
PDTriangleBasedShadingTypes which only cover a very small area.
For example with the device bounds [x=0,y=0,width=4031,height=2024] a bounding
rectangle, calculated in GouraudShadingContext.setTriangleList, around the
triangles for shading COSName\{Sh0} is only
[x=2916.300048828125,y=897.4940185546875,w=16.97998046875,h=17.0400390625]
Applying a Paint to such a small area should be much faster. I probably need
more time to look into how to calculate that beforehand and setting the
clipping area.
> Very slow rendering on PageDrawer.shadingFill
> -
>
> Key: PDFBOX-5134
> URL: https://issues.apache.org/jira/browse/PDFBOX-5134
> Project: PDFBox
> Issue Type: Bug
>Reporter: Oliver Schmidtmer
>Priority: Major
> Labels: shading
> Attachments: Plan zum Testen.pdf, image-2021-03-17-20-16-49-221.png
>
>
> The PDF contains many effectively very small shadings, the light cones. As
> the gradient painting for each light cone is applied on the whole image,
> rendering is very slow: 29 of 33 seconds are spent in shadingFill.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5134) Very slow rendering on PageDrawer.shadingFill
[
https://issues.apache.org/jira/browse/PDFBOX-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303733#comment-17303733
]
Oliver Schmidtmer commented on PDFBOX-5134:
---
That is correct, the slow painting is Java itself. However, the clipping area
is null and the paint applied to the whole image while those shades are
PDTriangleBasedShadingTypes which only cover a very small area.
For example with the device bounds [x=0,y=0,width=4031,height=2024] a bounding
rectangle, calculated in GouraudShadingContext.setTriangleList, around the
triangles for shading COSName\{Sh0} is only
[x=2916.300048828125,y=897.4940185546875,w=16.97998046875,h=17.0400390625]
Applying a Paint to such a small area should be much faster. I probably need
more time to look into how to calculate that beforehand and setting the
clipping area.
> Very slow rendering on PageDrawer.shadingFill
> -
>
> Key: PDFBOX-5134
> URL: https://issues.apache.org/jira/browse/PDFBOX-5134
> Project: PDFBox
> Issue Type: Bug
>Reporter: Oliver Schmidtmer
>Priority: Major
> Labels: shading
> Attachments: Plan zum Testen.pdf, image-2021-03-17-20-16-49-221.png
>
>
> The PDF contains many effectively very small shadings, the light cones. As
> the gradient painting for each light cone is applied on the whole image,
> rendering is very slow: 29 of 33 seconds are spent in shadingFill.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5134) Very slow rendering on PageDrawer.shadingFill
[ https://issues.apache.org/jira/browse/PDFBOX-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303676#comment-17303676 ] Tilman Hausherr commented on PDFBOX-5134: - I started the profiler and yes, the shadingFill takes the time, but then it's java itself?! > Very slow rendering on PageDrawer.shadingFill > - > > Key: PDFBOX-5134 > URL: https://issues.apache.org/jira/browse/PDFBOX-5134 > Project: PDFBox > Issue Type: Bug >Reporter: Oliver Schmidtmer >Priority: Major > Labels: shading > Attachments: Plan zum Testen.pdf, image-2021-03-17-20-16-49-221.png > > > The PDF contains many effectively very small shadings, the light cones. As > the gradient painting for each light cone is applied on the whole image, > rendering is very slow: 29 of 33 seconds are spent in shadingFill. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-5134) Very slow rendering on PageDrawer.shadingFill
[ https://issues.apache.org/jira/browse/PDFBOX-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tilman Hausherr updated PDFBOX-5134: Attachment: image-2021-03-17-20-16-49-221.png > Very slow rendering on PageDrawer.shadingFill > - > > Key: PDFBOX-5134 > URL: https://issues.apache.org/jira/browse/PDFBOX-5134 > Project: PDFBox > Issue Type: Bug >Reporter: Oliver Schmidtmer >Priority: Major > Labels: shading > Attachments: Plan zum Testen.pdf, image-2021-03-17-20-16-49-221.png > > > The PDF contains many effectively very small shadings, the light cones. As > the gradient painting for each light cone is applied on the whole image, > rendering is very slow: 29 of 33 seconds are spent in shadingFill. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303563#comment-17303563 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1887756 from le...@apache.org in branch 'pdfbox/trunk' [ https://svn.apache.org/r1887756 ] PDFBOX-4892: use convenience methods to simplify code, add new constants, optimize COSDictionary methods > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Created] (PDFBOX-5134) Very slow rendering on PageDrawer.shadingFill
Oliver Schmidtmer created PDFBOX-5134: - Summary: Very slow rendering on PageDrawer.shadingFill Key: PDFBOX-5134 URL: https://issues.apache.org/jira/browse/PDFBOX-5134 Project: PDFBox Issue Type: Bug Reporter: Oliver Schmidtmer Attachments: Plan zum Testen.pdf The PDF contains many effectively very small shadings, the light cones. As the gradient painting for each light cone is applied on the whole image, rendering is very slow: 29 of 33 seconds are spent in shadingFill. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5128) Support parsing non standardized XMP
[ https://issues.apache.org/jira/browse/PDFBOX-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303529#comment-17303529 ] Maruan Sahyoun commented on PDFBOX-5128: Thank you for providing the files. Will try to add handling some non standard files first and then run using the test bed. Not likely before early next week. > Support parsing non standardized XMP > - > > Key: PDFBOX-5128 > URL: https://issues.apache.org/jira/browse/PDFBOX-5128 > Project: PDFBox > Issue Type: Task > Components: XmpBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Attachments: PDFBOX.zip, image-2021-03-17-09-00-57-653.png > > > XMP currently only supports parsing known XMP schema as has been discussed. > That shall be extended to support arbitrary but valid XMP. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5128) Support parsing non standardized XMP
[ https://issues.apache.org/jira/browse/PDFBOX-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303522#comment-17303522 ] Tim Allison commented on PDFBOX-5128: - The process hasn't finished, but I'm dumping the files here: [https://corpora.tika.apache.org/base/xmps/] I'm roughly binning them by the file type of the container file, including: [https://corpora.tika.apache.org/base/xmps/pdf/] Let me know if I can do any processing on these or if I botched the extraction. > Support parsing non standardized XMP > - > > Key: PDFBOX-5128 > URL: https://issues.apache.org/jira/browse/PDFBOX-5128 > Project: PDFBox > Issue Type: Task > Components: XmpBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Attachments: PDFBOX.zip, image-2021-03-17-09-00-57-653.png > > > XMP currently only supports parsing known XMP schema as has been discussed. > That shall be extended to support arbitrary but valid XMP. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Comment Edited] (PDFBOX-5128) Support parsing non standardized XMP
[ https://issues.apache.org/jira/browse/PDFBOX-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303391#comment-17303391 ] Tim Allison edited comment on PDFBOX-5128 at 3/17/21, 1:01 PM: --- Side note...I'm looking at the EOFs for my xmp byte scanner, and I notice that Oracle Outside In (at least back in 2011) didn't include a closing packet – PDFBOX-1192 !image-2021-03-17-09-00-57-653.png! -- was (Author: talli...@mitre.org): Side note...I'm looking at the EOFs for my xmp byte scanner, and I notice that Oracle Outsid !image-2021-03-17-09-00-57-653.png! e In (at least back in 2011) didn't include a closing packet – PDFBOX-1192 > Support parsing non standardized XMP > - > > Key: PDFBOX-5128 > URL: https://issues.apache.org/jira/browse/PDFBOX-5128 > Project: PDFBox > Issue Type: Task > Components: XmpBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Attachments: PDFBOX.zip, image-2021-03-17-09-00-57-653.png > > > XMP currently only supports parsing known XMP schema as has been discussed. > That shall be extended to support arbitrary but valid XMP. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Updated] (PDFBOX-5128) Support parsing non standardized XMP
[ https://issues.apache.org/jira/browse/PDFBOX-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Allison updated PDFBOX-5128: Attachment: image-2021-03-17-09-00-57-653.png > Support parsing non standardized XMP > - > > Key: PDFBOX-5128 > URL: https://issues.apache.org/jira/browse/PDFBOX-5128 > Project: PDFBox > Issue Type: Task > Components: XmpBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Attachments: PDFBOX.zip, image-2021-03-17-09-00-57-653.png > > > XMP currently only supports parsing known XMP schema as has been discussed. > That shall be extended to support arbitrary but valid XMP. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5128) Support parsing non standardized XMP
[ https://issues.apache.org/jira/browse/PDFBOX-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303391#comment-17303391 ] Tim Allison commented on PDFBOX-5128: - Side note...I'm looking at the EOFs for my xmp byte scanner, and I notice that Oracle Outsid !image-2021-03-17-09-00-57-653.png! e In (at least back in 2011) didn't include a closing packet – PDFBOX-1192 > Support parsing non standardized XMP > - > > Key: PDFBOX-5128 > URL: https://issues.apache.org/jira/browse/PDFBOX-5128 > Project: PDFBox > Issue Type: Task > Components: XmpBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Attachments: PDFBOX.zip, image-2021-03-17-09-00-57-653.png > > > XMP currently only supports parsing known XMP schema as has been discussed. > That shall be extended to support arbitrary but valid XMP. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-5128) Support parsing non standardized XMP
[ https://issues.apache.org/jira/browse/PDFBOX-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303266#comment-17303266 ] Maruan Sahyoun commented on PDFBOX-5128: [~tallison] yes, that's fine [~pwyatt] thank's for the information. I'll look into that as soon as I have the base stuff working > Support parsing non standardized XMP > - > > Key: PDFBOX-5128 > URL: https://issues.apache.org/jira/browse/PDFBOX-5128 > Project: PDFBox > Issue Type: Task > Components: XmpBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Attachments: PDFBOX.zip > > > XMP currently only supports parsing known XMP schema as has been discussed. > That shall be extended to support arbitrary but valid XMP. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[GitHub] [pdfbox] wdick opened a new pull request #108: PDFBOX-xxxx: Add COSName for DocMDP
wdick opened a new pull request #108: URL: https://github.com/apache/pdfbox/pull/108 Add COSNames needed to read DocMDP settings see PDF 32000-1:2008, Table 253 – Entries in a signature reference dictionary This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4892) Improve code quality (4)
[ https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303149#comment-17303149 ] ASF subversion and git services commented on PDFBOX-4892: - Commit 1887747 from le...@apache.org in branch 'pdfbox/trunk' [ https://svn.apache.org/r1887747 ] PDFBOX-4892: use convenience methods to simplify code > Improve code quality (4) > > > Key: PDFBOX-4892 > URL: https://issues.apache.org/jira/browse/PDFBOX-4892 > Project: PDFBox > Issue Type: Improvement >Affects Versions: 2.0.20 >Reporter: Tilman Hausherr >Priority: Minor > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-4071, which was getting too long. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
