[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908783#comment-16908783 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865274 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865274 ] PDFBOX-4080: remove unused import > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908784#comment-16908784 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865275 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865275 ] PDFBOX-4080: remove unused import > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908785#comment-16908785 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865276 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865276 ] PDFBOX-4080: remove unused import > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908333#comment-16908333 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865246 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865246 ] PDFBOX-4080: use new method to lessen memory footprint, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908332#comment-16908332 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865245 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865245 ] PDFBOX-4080: use new method to lessen memory footprint, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908330#comment-16908330 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865244 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865244 ] PDFBOX-4080: use new method to lessen memory footprint, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908331#comment-16908331
]
Ghenadii Batalski commented on PDFBOX-4080:
---
[~tilman] sorry, the removal of the
{{appearanceDictionary.setRolloverAppearance}} was just a mistake
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 2.0.16, 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908322#comment-16908322 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865242 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865242 ] PDFBOX-4080: change new method name and return class > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908321#comment-16908321 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865241 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865241 ] PDFBOX-4080: change new method name and return class > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908323#comment-16908323 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865243 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865243 ] PDFBOX-4080: change new method name and return class > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908307#comment-16908307 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865240 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865240 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908306#comment-16908306 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865239 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865239 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908305#comment-16908305 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865238 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865238 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907547#comment-16907547 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865183 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865183 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907545#comment-16907545 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865181 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865181 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907546#comment-16907546 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865182 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865182 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906580#comment-16906580
]
Maruan Sahyoun commented on PDFBOX-4080:
{quote}
Also need to think whether to deprecate (2.0) / remove (trunk) the no-parameter
methods / constructors.
{quote}
That's something I'd keep as it gives us the freedom to have another
implementation (wo PDDocument) at a later stage wo affecting the API
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 2.0.16, 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906546#comment-16906546 ] Tilman Hausherr commented on PDFBOX-4080: - more tomorrow. Also need to think whether to deprecate (2.0) / remove (trunk) the no-parameter methods / constructors. > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906513#comment-16906513 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865066 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865066 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906512#comment-16906512 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865065 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865065 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906510#comment-16906510 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865064 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865064 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 2.0.16, 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906476#comment-16906476 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865063 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865063 ] PDFBOX-4080: pass PDDocument to construct appearances + use existing scratch file when possible, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906475#comment-16906475 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865062 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865062 ] PDFBOX-4080: pass PDDocument to construct appearances + use existing scratch file when possible, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906472#comment-16906472 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865061 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865061 ] PDFBOX-4080: pass PDDocument to construct appearances + use existing scratch file when possible, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906439#comment-16906439 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865058 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865058 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906440#comment-16906440 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865059 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865059 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906442#comment-16906442 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865060 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865060 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906435#comment-16906435 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865054 from Tilman Hausherr in branch 'pdfbox/trunk' [ https://svn.apache.org/r1865054 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906436#comment-16906436 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865055 from Tilman Hausherr in branch 'pdfbox/branches/issue4569' [ https://svn.apache.org/r1865055 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906434#comment-16906434 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1865053 from Tilman Hausherr in branch 'pdfbox/branches/2.0' [ https://svn.apache.org/r1865053 ] PDFBOX-4080: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906407#comment-16906407 ] Maruan Sahyoun commented on PDFBOX-4080: [~tilman] fine for me > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906383#comment-16906383
]
Tilman Hausherr commented on PDFBOX-4080:
-
Yes, passing {{PDDocument}} is a good idea because it would also solve another
recent problem with FreeText annotations:
[https://stackoverflow.com/questions/57450039/]
Here we'd need to put a chinese font into the acroform default resources.
Similar problem with the file here:
[https://gitlab.freedesktop.org/poppler/poppler/issues/6]
the FreeText annotation should use the font "Impact".
[~msahyoun] do you support that change?
[~gena77] why removal of the
{{appearanceDictionary.setRolloverAppearance(rolloverAppearanceEntry);}} line?
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906110#comment-16906110 ] Ghenadii Batalski commented on PDFBOX-4080: --- Hello all, i've done a very naive improvement. But it helped me at leaset to solve the problem with the PDAnnotationLink. Please take a look at [https://github.com/apache/pdfbox/pull/72] > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375608#comment-16375608 ] Tilman Hausherr commented on PDFBOX-4080: - I didn't criticize the code. I just mean it should be documented that the new method is for "experienced users only" and that each stream uses a 4096 byte page of this count so one should know in advance how much memory and how many bytes it will use. > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370462#comment-16370462
]
Maruan Sahyoun commented on PDFBOX-4080:
Yes, but let's say that we do adjust the handler, wouldn't that potentially use
more memory and so again we get an IOException. Might not be the case for our
own handlers but if one is extending {{PDAbstractAppearanceHandler}} then we
might hit that issue. That's what made me a little bit reluctant to introduce
it.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370452#comment-16370452
]
Tilman Hausherr commented on PDFBOX-4080:
-
I didn't understand your comment, slept over it twice, then tried to use the
method, and found out that we need 4096 per stream, and now it all makes sense.
So this code works for the highlight handler:
{code}
ScratchFile scratchFile = new
ScratchFile(MemoryUsageSetting.setupMainMemoryOnly(4096 * 2));
PDFormXObject frm1 = new PDFormXObject(new COSStream(scratchFile));
PDFormXObject frm2 = new PDFormXObject(new COSStream(scratchFile));
{code}
The code no longer works when using 1 byte less. So if we restrict the memory,
we need 4096 per stream, probably because each stream will use one "page" of
the scratch file.
Please add some comment to the new method so that we don't get support calls on
this one.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368595#comment-16368595
]
Maruan Sahyoun commented on PDFBOX-4080:
[~tilman] I've tested with different buffer sizes but had to set the size to
{{4096}} to not fail our own tests with {{java.io.IOException: Maximum allowed
scratch file memory exceeded.}}. So I decided to not use the limited size
buffer as it seems to risky that more complex content will fail appearance
generation. I'll leave the new method in {{ScratchFile}} though that if one is
really sure that a certain size is not exceeded this method can be used. To me
one of the options is to work with a smaller initial buffer but that's beyond
this ticket I think.
If you're fine I'll close it for now.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368588#comment-16368588 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1824674 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1824674 ] PDFBOX-4080: add static method ScratchFile.getMainMemoryOnlyInstance(long maxMainMemoryBytes) > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368565#comment-16368565 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1824671 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1824671 ] PDFBOX-4080: remove ScratchFile parameter from javadoc > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368339#comment-16368339 ] Tilman Hausherr commented on PDFBOX-4080: - javadoc build failed: PDAnnotation.java:807: error: @param name not found > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368296#comment-16368296
]
Tilman Hausherr commented on PDFBOX-4080:
-
How about a new static method {{ScratchFile.getMainMemoryOnlyInstance(long
maxMainMemoryBytes)}}? That one wouldn't throw an exception.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368257#comment-16368257
]
Maruan Sahyoun commented on PDFBOX-4080:
[~tilman] I'm leaving it without the {{new ScratchFile(..)}} parameter for now
although this would help as this will introduce a potential {{IOException}}
when trying to get the appearance. I'll leave the ticket open but remove the
3.0 target.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368254#comment-16368254 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1824603 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1824603 ] PDFBOX-4080: remove ScratchFile parameter for now > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368253#comment-16368253 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1824602 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1824602 ] PDFBOX-4080: remove ScratchFile parameter for now > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368210#comment-16368210
]
Tilman Hausherr commented on PDFBOX-4080:
-
I don't mind... another (temporary) solution would be to modify
INIT_UNRESTRICTED_MAINMEM_PAGECOUNT to something less. However I don't know if
there are any downsides to start with a values that is too small.
Or that we use code like this in the handlers:
{code}
new COSStream(new ScratchFile(MemoryUsageSetting.setupMainMemoryOnly(1024)));
{code}
This would leave a smaller memory footprint.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
> Fix For: 3.0.0 PDFBox
>
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368203#comment-16368203
]
Maruan Sahyoun commented on PDFBOX-4080:
[~tilman] I looked at various ways to improve that but all ends up being a lot
of ugly code (IMHO) with passing {{ScratchFile}} or {{COSDocument}} all around.
In addition working with {{COSStream}} is currently very complicated as it's
not easy to close it ...
So my proposal is to move that to after 3.0 and remove the ScratchFile
parameter so we can introduce a better API after having tackled a clean
approach - WDYT?
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
> Fix For: 3.0.0 PDFBox
>
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355907#comment-16355907 ] Tilman Hausherr commented on PDFBOX-4080: - We could create one scratch file and then reuse that one for all annotations, this would save memory. I looked at COSOutputStream... yes, that's one //TODO that was forgotten. Or it is too tricky. The problem is that RandomAccess is not an InputStream or an OutputStream. One would have to write some sort of wrapper... About the rest... maybe. I don't really have a good thought to share. > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355070#comment-16355070
]
Maruan Sahyoun commented on PDFBOX-4080:
What about keeping the implementation as is and use the {{ScratchFile}} within
the apperance handlers. This will allow to manually pass the {{ScratchFile}}.
In addition we can change the objects so that the {{PDDocument}} or
{{COSDocument}} or a config object (this way we could extend it later) is
passed from top to bottom - Document, Page, Annotation ... - and kept in a
member either with {{new PDPage}} and similar or when we do
{{PDDocument.addPage}} and similar.
Then within the appearance handler we could check for the annotation if that is
set. If yes and the ScratchFile hasn't been passed in the method call we could
use that ScratchFile. If it hasn't been set we could then still use
{{ScratchFile.getMainMemoryOnlyInstance()}}.
So the user creates PDFs adding the PDF Objects such as annotation or page to
their parents *before* adding the content the user benefits from the improved
memory.
WDYT?
We also need to make sure that {{COSOutputStream}} actuall uses the
{{ScratchFile}} for writing.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
> Fix For: 3.0.0 PDFBox
>
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354980#comment-16354980
]
Tilman Hausherr commented on PDFBOX-4080:
-
{{new COSStream()}} calls {{ScratchFile.getMainMemoryOnlyInstance()}}. That one
calls {{new {{ScratchFile(MemoryUsageSetting.setupMainMemoryOnly())}}. And
{{new ScratchFile()}} allocates a byte array with size 10.
Yes that's why calling {{createCOSStream()}} is the better thing to do.
I agree that it is not a high priority but it should be kept in mind and fixed
before release.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
> Fix For: 3.0.0 PDFBox
>
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354640#comment-16354640
]
Maruan Sahyoun commented on PDFBOX-4080:
Mhmm - I might be mistaken but the ScratchFile seems to be intented when
reading a document not when generating a new one. E.g. {{COSOutputStream}} is
not using the ScratchFile even if you could pass one for output. So it needs
more changes.
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
> Fix For: 3.0.0 PDFBox
>
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354454#comment-16354454 ] Tilman Hausherr commented on PDFBOX-4080: - I was wrong re: passing scratch file - the problem is that we can't access the scratch file at all. Either we must have a way to get the scratch file or we'd need to pass the PDDocument. > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341224#comment-16341224 ] Tilman Hausherr commented on PDFBOX-4080: - None. Storing the scratch file in the PDAnnotation object would bring other problems. And creating a "lean" scratchFile that would only use the memory needed would bring new risks. > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[
https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340638#comment-16340638
]
Maruan Sahyoun commented on PDFBOX-4080:
OK - I've added the parameter but for now haven't implemented it within the
handlers to pass that on. What I would like is to come up with a solution where
we don't have to pass this around if doable as I find it very unintuitive that
this is needed at that level but I haven't looked into the whole
{{ScratchFile}} mechanism up to know. Usage of the "memory model" should be
transparent to the user after setting that with {{PDDocument.load()}} IMHO.
I'd like to get rid of that parameter.
Ideas?
> Improve memory consumption of PDAbstractAppearanceHandler
> -
>
> Key: PDFBOX-4080
> URL: https://issues.apache.org/jira/browse/PDFBOX-4080
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
>Affects Versions: 3.0.0 PDFBox
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Major
> Labels: Annotations
> Fix For: 3.0.0 PDFBox
>
>
> PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory
> footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the
> document, or the document scratch file, or there will be trouble for files
> with many annotations, e.g. a long scientific document with many footnotes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339599#comment-16339599 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1822213 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1822213 ] PDFBOX-4080: update example to use ScratchFile > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339556#comment-16339556 ] ASF subversion and git services commented on PDFBOX-4080: - Commit 1822209 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1822209 ] PDFBOX-4080: allow to pass a ScratchFile to constructAppearances(); needs further changes within appearance handlers > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339514#comment-16339514 ] Tilman Hausherr commented on PDFBOX-4080: - How about passing the document or the scratch file in constructAppearances? It should then be passed to generateAppearanceStreams() and then to the actual methods if needed. My first thought was to pass the document because it is easier to understand. OTOH passing the scratch file means passing only what we really need. > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4080) Improve memory consumption of PDAbstractAppearanceHandler
[ https://issues.apache.org/jira/browse/PDFBOX-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339004#comment-16339004 ] Maruan Sahyoun commented on PDFBOX-4080: [~tilman] maybe we could have a quick chat about approaching this. > Improve memory consumption of PDAbstractAppearanceHandler > - > > Key: PDFBOX-4080 > URL: https://issues.apache.org/jira/browse/PDFBOX-4080 > Project: PDFBox > Issue Type: Improvement > Components: PDModel >Affects Versions: 3.0.0 PDFBox >Reporter: Maruan Sahyoun >Assignee: Maruan Sahyoun >Priority: Major > Labels: Annotations > Fix For: 3.0.0 PDFBox > > > PDAbstractAppearanceHandler calls new COSStream(), this has a huge memory > footprint (PDFBOX-3868 and PDFBOX-3852). We'd need to find a way to pass the > document, or the document scratch file, or there will be trouble for files > with many annotations, e.g. a long scientific document with many footnotes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
