Re: [patch] perlrequire test + APACHE_TEST_CONFIGURE

2001-09-17 Thread Stas Bekman
> you can use now. and have the .t skip > based on $Config{useithreads}. cool, but the skipped test is not good. e.g. PerlRequire is not ithreads specific. I will adjust the test to skip the second sub-test based on $Config{useithreads}. thanks! ___

Re: [patch] perlrequire test + APACHE_TEST_CONFIGURE

2001-09-17 Thread Doug MacEachern
you can use now. and have the .t skip based on $Config{useithreads}. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [patch] perlrequire test + APACHE_TEST_CONFIGURE

2001-09-17 Thread Stas Bekman
On Mon, 17 Sep 2001, Doug MacEachern wrote: > server won't start with non-ithreads Perl: ouch :( > Syntax error on line 103 of > /home/dougm/ap/modperl-2.0/t/conf/httpd.conf: > PerlOption `Parent' requires an ithreads enabled Perl > > should be able to have the test check $Config{useithreads} a

Re: genwarning constants

2001-09-17 Thread Doug MacEachern
On Tue, 18 Sep 2001, Stas Bekman wrote: > It's a good idea to let the code decide which comment style to use, but I > won't drop the explicit option yet. So we can probably add the code from > above and remove the WARN_STYLE_ arg in most calls to genfile, but still > keep the explicit option aro

Re: [patch] perlrequire test + APACHE_TEST_CONFIGURE

2001-09-17 Thread Doug MacEachern
server won't start with non-ithreads Perl: Syntax error on line 103 of /home/dougm/ap/modperl-2.0/t/conf/httpd.conf: PerlOption `Parent' requires an ithreads enabled Perl should be able to have the test check $Config{useithreads} and adjust things accordingly. ---

Re: [patch] correcting Apache::Test::plan

2001-09-17 Thread Doug MacEachern
+1, don't forget to update all the httpd-test tests :) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: genwarning constants

2001-09-17 Thread Stas Bekman
On Mon, 17 Sep 2001, Doug MacEachern wrote: > On Tue, 18 Sep 2001, Stas Bekman wrote: > > > +use constant WARN_STYLE_NONE => 0; > > +use constant WARN_STYLE_PERL => 1; > > +use constant WARN_STYLE_C=> 2; > > one thing to consider though, ModPerl::Code has > noedit_warning_{c,hash} and this co

Re: genwarning constants

2001-09-17 Thread Doug MacEachern
On Tue, 18 Sep 2001, Stas Bekman wrote: > +use constant WARN_STYLE_NONE => 0; > +use constant WARN_STYLE_PERL => 1; > +use constant WARN_STYLE_C=> 2; one thing to consider though, ModPerl::Code has noedit_warning_{c,hash} and this comment: #this is named hash after the `#' character #rathe

[patch] correcting Apache::Test::plan

2001-09-17 Thread Stas Bekman
according to the Apache::Test::plan's docs, it extends Test::plan and passes all the args to Test::plan, but the last one, if it's a reference -- that's where the extended logic is hidden. But the problem is that if you look at the Test's manpage, it says: BEGIN { plan tests => 14, todo => [3,4

Re: RFC: Apache::Registry family re-design

2001-09-17 Thread Stas Bekman
On Mon, 17 Sep 2001, Ken Williams wrote: > > Stas Bekman <[EMAIL PROTECTED]> wrote: > > The point is to write a library of standalone functions implemented in > > Perl and C, and let the final products be Lego-like, just pick what you > > want and if you want to have 10 different Registry modules

Re: Parent/Clone?

2001-09-17 Thread Stas Bekman
On Mon, 17 Sep 2001, Doug MacEachern wrote: > On Mon, 17 Sep 2001, Stas Bekman wrote: > > > What's the exact difference between the two? If parent implies Clone, > > how is it different? > > +Clone will share the parent interpreter, but give the vhost its own > interpreter pool > > +Parent will

Re: genwarning constants

2001-09-17 Thread Stas Bekman
On Mon, 17 Sep 2001, Doug MacEachern wrote: > On Mon, 17 Sep 2001, Stas Bekman wrote: > > > > - use better API naming s/warn/warn_type/. it's not clear what 'warn' is. > > > > I still don't like the use of raw numbers 1, 2 for > > Apache::TestConfig::genwarning. We try to make the code self-docum

Re: [patch] perlrequire test + APACHE_TEST_CONFIGURE

2001-09-17 Thread Stas Bekman
Doug MacEachern wrote: > On Mon, 17 Sep 2001, Stas Bekman wrote: > > >>OK, using the patch I've just sent for auto-mkpath and using all the >>latest patches, makes the perlrequire test short and sweet: >> > > looks good, but i would fold the duplicated code into something like this: > > my %r

Re: [Patch] Apache::TestConfigParse and Taint mode

2001-09-17 Thread Stas Bekman
Randal L. Schwartz wrote: >>"Stas" == Stas Bekman <[EMAIL PROTECTED]> writes: >> > > Stas> this is still nicer, as it does the split at compile time : > Stas> qw(PATH IFS CDPATH ENV BASH_ENV) > > Only in recent Perls. > > For those of us still stuck at 5.5.3 (grumble grumble), it's > a

Re: genwarning constants

2001-09-17 Thread Doug MacEachern
On Mon, 17 Sep 2001, Stas Bekman wrote: > > - use better API naming s/warn/warn_type/. it's not clear what 'warn' is. > > I still don't like the use of raw numbers 1, 2 for > Apache::TestConfig::genwarning. We try to make the code self-documenting, > so let's do that. > > May I add: > > use

Re: [patch] perlrequire test + APACHE_TEST_CONFIGURE

2001-09-17 Thread Doug MacEachern
On Mon, 17 Sep 2001, Stas Bekman wrote: > OK, using the patch I've just sent for auto-mkpath and using all the > latest patches, makes the perlrequire test short and sweet: looks good, but i would fold the duplicated code into something like this: my %require_tests = ( main => 'Loaded by Pa

Re: a couple of random questions

2001-09-17 Thread Doug MacEachern
On Mon, 17 Sep 2001, Stas Bekman wrote: > it does change quite a few lines in the source, but I'd rather have more > intuitive configuration, since many more people will use it and not the > code. actually, it only requires changing 4 lines in the source code :) ---

Re: Parent/Clone?

2001-09-17 Thread Doug MacEachern
On Mon, 17 Sep 2001, Stas Bekman wrote: > What's the exact difference between the two? If parent implies Clone, > how is it different? +Clone will share the parent interpreter, but give the vhost its own interpreter pool +Parent will create a new parent interpreter for the given vhost and hav

Re: perlbloat util?

2001-09-17 Thread Doug MacEachern
On Mon, 17 Sep 2001, Stas Bekman wrote: > before I generate a bunch of cvs messages, please confirm my choice. > > util/build/*.pl > > util/*.pl actually, i'd rather see: util/ (stuff run by hand) build/ (stuff run by the build) ---

Re: [patch] Re: genfile and gendir to emulate mkdir -p

2001-09-17 Thread Doug MacEachern
On Mon, 17 Sep 2001, Stas Bekman wrote: patch looks good, +1 > If you agree with me that _makepath should be made private as in my patch, > I also suggest that genwarning() is made private too. I don't see a reason > why any of these two should be exposed outside. > > Hmm, doesn't it make sens

Re: [Patch] Apache::TestConfigParse and Taint mode

2001-09-17 Thread Randal L. Schwartz
> "Stas" == Stas Bekman <[EMAIL PROTECTED]> writes: Stas> this is still nicer, as it does the split at compile time : Stas> qw(PATH IFS CDPATH ENV BASH_ENV) Only in recent Perls. For those of us still stuck at 5.5.3 (grumble grumble), it's a runtime split. -- Randal L. Schwartz - Stonehen

Re: Apache::Registry family re-design

2001-09-17 Thread Stas Bekman
Ken Williams wrote: > Stas Bekman <[EMAIL PROTECTED]> wrote: > >> On Sat, 8 Sep 2001, raptor wrote: >> >>> my $eval = join ( '', qq{ >>> package $package; >>> my $request; >>> START: >>> use Apache qw(exit); >>> $usercode >>> sub handler { >>> $package::re

Re: Apache::Registry family re-design

2001-09-17 Thread Ken Williams
Stas Bekman <[EMAIL PROTECTED]> wrote: > On Sat, 8 Sep 2001, raptor wrote: >> my $eval = join ( '', qq{ >> package $package; >> my $request; >> START: >> use Apache qw(exit); >> $usercode >> sub handler { >> $package::request = \$r; >> goto START;

Re: [Patch] Apache::TestConfigParse and Taint mode

2001-09-17 Thread Stas Bekman
Ken Williams wrote: > > Stas Bekman <[EMAIL PROTECTED]> wrote: > >> According to perlsec manpage this is what should be done: >> >>$ENV{'PATH'} = '/bin:/usr/bin'; >>delete @ENV{'IFS', 'CDPATH', 'ENV', 'BASH_ENV'}; >> >> hence in this particular case the patch should be:

Re: RFC: Apache::Registry family re-design

2001-09-17 Thread Ken Williams
Stas Bekman <[EMAIL PROTECTED]> wrote: > The point is to write a library of standalone functions implemented in > Perl and C, and let the final products be Lego-like, just pick what you > want and if you want to have 10 different Registry modules, doing > similar but yet different things, you can

Re: vs

2001-09-17 Thread Ken Williams
Doug MacEachern <[EMAIL PROTECTED]> wrote: > > i'd rather see: > This is a cool idea - I assume it means that any package can be specified, and the default is Apache::ReadConfig. I think that would place a little meme-fleck into people's brains to remind them that the default package is Apache

Re: [Patch] Apache::TestConfigParse and Taint mode

2001-09-17 Thread Ken Williams
Stas Bekman <[EMAIL PROTECTED]> wrote: > According to perlsec manpage this is what should be done: > >$ENV{'PATH'} = '/bin:/usr/bin'; >delete @ENV{'IFS', 'CDPATH', 'ENV', 'BASH_ENV'}; > > hence in this particular case the patch should be: > > local %ENV; > delete @ENV{

inline docs vs external docs

2001-09-17 Thread Stas Bekman
If you follow the docs-cvs mailing list you have noticed that I've been working recently on writing the doc on writing tests. The problem is that I cannot decide where the documents should go: On one side we need to have inlined docs of the functions so one can easily lookup needed features vi

Re: a couple of random questions

2001-09-17 Thread Stas Bekman
Cleaning up my mail box. Doug MacEachern wrote: > On Fri, 29 Jun 2001, Stas Bekman wrote: >>modperl_dev.pod: >>--- >>=head2 PerlOptions Directive >> >>Is the option called 'Enabled' or 'Enable'? the item says 'Enabled' >>but the example following it uses 'PerlOptions -Enable

Parent/Clone?

2001-09-17 Thread Stas Bekman
What's the exact difference between the two? If parent implies Clone, how is it different? =item Parent Create a new parent Perl interpreter for the given VirtualHost (implies Clone). =item Clone Give the VirtualHost its own interpreter pool. Thanks! __

Re: perlbloat util?

2001-09-17 Thread Stas Bekman
before I generate a bunch of cvs messages, please confirm my choice. Stas Bekman wrote: > On Wed, 12 Sep 2001, Doug MacEachern wrote: > > >>On Tue, 11 Sep 2001, Stas Bekman wrote: >> >> >>>Doug, this is something that you wrote a while ago. I thought to add it as >>>util/perlbloat.pl ? >>> >>s