Re: cvs commit: modperl-2.0/xs/maps apr_functions.map

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > On 30 Jan 2002 [EMAIL PROTECTED] wrote: > > >>stas02/01/29 22:57:31 >> >> Modified:xs/maps apr_functions.map >> Log: >> - package guessing was wrong, was using APR::function instead of >> APR::Util::function. remove guessing. >> > > no, the guessing is

functions returning status?

2002-01-29 Thread Stas Bekman
e.g. APR::Util::password_validate returns status, which is not what a Perl user expects. Since we try to adjust the APR's API to follow Perl style, I've "fixed" APR::Util::password_validate to DWIM. The patch is below. The question remains is how to get to the value of the status, since the c

Re: cvs commit: modperl-2.0/xs/maps apr_functions.map

2002-01-29 Thread Doug MacEachern
On 30 Jan 2002 [EMAIL PROTECTED] wrote: > stas02/01/29 22:57:31 > > Modified:xs/maps apr_functions.map > Log: > - package guessing was wrong, was using APR::function instead of > APR::Util::function. remove guessing. no, the guessing is correct. APR::strerror is right, Apa

Re: validate_password or password_validate?

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > first, the APR::Lib => APR::Util rename should take place. ok, shell we mv APR__Lib.h directly in cvs to preserve history or just delete/add/commit? I've adjusted all the files already, rebuilding everything to test that I didn't break anything. _

Re: validate_password or password_validate?

2002-01-29 Thread Doug MacEachern
first, the APR::Lib => APR::Util rename should take place. then just add to compat.pm: sub Apache::Util::validate_password { APR::Util::password_validate(@_) == APR::SUCCESS; } - To unsubscribe, e-mail: [EMAIL PROTECTED] F

Re: apr_strfsize cannot handle sizes bigger than a few MiBs without largefiles support

2002-01-29 Thread Stas Bekman
wrong list :( time to hit the floor... > apr_strfsize accepts the size arg as apr_off_t, so unless apache it > built with largefiles support, apr_off_t == long int, which means that > apr_strfsize is unusable for sizes bigger than a few MiBs. __

apr_strfsize cannot handle sizes bigger than a few MiBs without largefiles support

2002-01-29 Thread Stas Bekman
apr_strfsize accepts the size arg as apr_off_t, so unless apache it built with largefiles support, apr_off_t == long int, which means that apr_strfsize is unusable for sizes bigger than a few MiBs. I've checked mod_autoindex, and it has this problem too as it uses apr_off_t for its size and fe

Re: [patch take2] ht_time interface

2002-01-29 Thread Doug MacEachern
On Wed, 30 Jan 2002, Stas Bekman wrote: > What do you mean? if ap_ht_time changes to apr_date_format_http, then Apache::Time::ht_time changes to APR::Date::format_http. - To unsubscribe, e-mail: [EMAIL PROTECTED] For addition

validate_password or password_validate?

2002-01-29 Thread Stas Bekman
Should we have - Apache::Util::validate_password for apr_password_validate or - Apache::Util::password_validate and Apache::Util::validate_password wrapper in compat? _ Stas Bekman JAm_pH -- Just Another mod

Re: [patch take2] ht_time interface

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > On Wed, 30 Jan 2002, Stas Bekman wrote: > > >>Here is the new patch that picks the default_pool in compat.pm from >>Apache->request, per our recent discussion. >> >>- interface to Apache::Time::ht_time >>- compat wrapper Apache::Util::ht_time >>- tests for Apache::Time

Re: [patch] ht_time interface

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > btw - i also wonder if ht_time should be part of apr_date_*, since it > isn't tied to any apache structures. maybe ask apr-dev what they think. > i think there's more httpd util functions that could be moved to apr-util, > just hasn't happened yet. ok, will ask. _

Re: [patch] ht_time interface

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > On Wed, 30 Jan 2002, Stas Bekman wrote: > > >>- interface to Apache::Time::ht_time >>- compat wrapper Apache::Util::ht_time ( needs >>APR::Pool::from_current_request) >>- tests for Apache::Time::ht_time and the wrapper Apache::Util >> > > +1 > btw, i just realized the

Re: [patch take2] ht_time interface

2002-01-29 Thread Doug MacEachern
On Wed, 30 Jan 2002, Stas Bekman wrote: > Here is the new patch that picks the default_pool in compat.pm from > Apache->request, per our recent discussion. > > - interface to Apache::Time::ht_time > - compat wrapper Apache::Util::ht_time > - tests for Apache::Time::ht_time and the wrapper Apach

[patch take2] ht_time interface

2002-01-29 Thread Stas Bekman
Here is the new patch that picks the default_pool in compat.pm from Apache->request, per our recent discussion. - interface to Apache::Time::ht_time - compat wrapper Apache::Util::ht_time - tests for Apache::Time::ht_time and the wrapper Apache::Util Index: xs/maps/apache_functions.map

Re: [patch] ht_time interface

2002-01-29 Thread Doug MacEachern
btw - i also wonder if ht_time should be part of apr_date_*, since it isn't tied to any apache structures. maybe ask apr-dev what they think. i think there's more httpd util functions that could be moved to apr-util, just hasn't happened yet. --

Re: [patch] ht_time interface

2002-01-29 Thread Doug MacEachern
On Wed, 30 Jan 2002, Stas Bekman wrote: > - interface to Apache::Time::ht_time > - compat wrapper Apache::Util::ht_time ( needs > APR::Pool::from_current_request) > - tests for Apache::Time::ht_time and the wrapper Apache::Util +1 btw, i just realized there's no need for a new function, you sho

Re: cvs commit: modperl-2.0/xs/maps apr_functions.map modperl_functions.map

2002-01-29 Thread Doug MacEachern
On Wed, 30 Jan 2002, Stas Bekman wrote: > done cool, thanks. > Should I? My scan generates different tables then yours. If you say it's > OK, I'll always commit the tables when I change/add APIs. actually, the tables don't need to be updated now that the apr_strftime prototype is used in a

Re: [patch] default request pool sub

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > On Wed, 30 Jan 2002, Stas Bekman wrote: > > >>Sure, be it ModPerl::Util:: function. How should it be called? Can I use >>the same code I've used for APR::Pool::from_current_request() in my orig >>post. >> > > ModPerl::Util::default_pool(); so as you say below, we

Re: [patch] default request pool sub

2002-01-29 Thread Doug MacEachern
On Wed, 30 Jan 2002, Stas Bekman wrote: > Sure, be it ModPerl::Util:: function. How should it be called? Can I use > the same code I've used for APR::Pool::from_current_request() in my orig > post. ModPerl::Util::default_pool(); > Take the case of the Apache::Util::ht_time wrapper. We canno

Re: [patch] ht_time interface

2002-01-29 Thread Stas Bekman
Sorry, I'm lost today, forgot this file: diff -u /dev/null xs/Apache/Time/Apache__Time.h --- /dev/null Thu Jan 1 07:30:00 1970 +++ xs/Apache/Time/Apache__Time.h Tue Jan 29 16:23:01 2002 @@ -0,0 +1,5 @@ +#define TIME_NOW apr_time_now() + +#define DEFAULT_TIME_FORMAT "%A, %d-%b-%Y %H:%M:%S

Re: cvs commit: modperl-2.0/xs/maps apr_functions.map modperl_functions.map

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > On 29 Jan 2002 [EMAIL PROTECTED] wrote: > > >> +-apr_strfsize >> > > the stuff below should be here, like: > apr_strfsize | mpxs_APR__String_strfsize | buf | format_size > done > also, i think you forgot to checkin xs/APR/String/APR__String.h Sorry, committ

Re: cvs commit: modperl-2.0/xs/maps apr_functions.map modperl_functions.map

2002-01-29 Thread Doug MacEachern
On 29 Jan 2002 [EMAIL PROTECTED] wrote: > +-apr_strfsize the stuff below should be here, like: apr_strfsize | mpxs_APR__String_strfsize | buf | format_size > --- modperl_functions.map 21 Jan 2002 08:27:30 - 1.33 > +++ modperl_functions.map 29 Jan 2002 07:47:25 -

Re: [patch] default request pool sub

2002-01-29 Thread Stas Bekman
Doug MacEachern wrote: > On Tue, 29 Jan 2002, Stas Bekman wrote: > > >>I'm not sure if I've picked the best name, but I need this wrapper for >>compat. If I have it I don't need to prototype functions required to >>provide the pool argument as p=SOME_DEFAULT, but just p, >> >>So now in compat

[patch] ht_time interface

2002-01-29 Thread Stas Bekman
- interface to Apache::Time::ht_time - compat wrapper Apache::Util::ht_time ( needs APR::Pool::from_current_request) - tests for Apache::Time::ht_time and the wrapper Apache::Util Index: xs/maps/apache_functions.map === RCS file: /h

Re: [patch] default request pool sub

2002-01-29 Thread Doug MacEachern
On Tue, 29 Jan 2002, Stas Bekman wrote: > I'm not sure if I've picked the best name, but I need this wrapper for > compat. If I have it I don't need to prototype functions required to > provide the pool argument as p=SOME_DEFAULT, but just p, > > So now in compat.pm we can write wrappers: > >

[patch] default request pool sub

2002-01-29 Thread Stas Bekman
I'm not sure if I've picked the best name, but I need this wrapper for compat. If I have it I don't need to prototype functions required to provide the pool argument as p=SOME_DEFAULT, but just p, So now in compat.pm we can write wrappers: my $req_pool = APR::Pool::from_current_request(); APR:

[Fwd: cvs commit: modperl-docs/src/docs/2.0/user/compat compat.pod]

2002-01-29 Thread Stas Bekman
I've committed a doc together with code and it decided to send email to docs-cvs list instead of dev-cvs. I guess all the interested parties should be on both lists in order not to miss various commits. Original Message Subject: cvs commit: modperl-docs/src/docs/2.0/user/compa