RE : [PATCH] add PERL5LIB to @INC in the correct order

2003-10-18 Thread Ayhan Ulusoy
Taint mode is another business. It is the "paranoid" mode, where anything that comes from the outside world, including the environment, is considered untrusted by default, until you explicitly untaint it. If I, *) know (or guess) that your code calls SomeModule->doSomething(), *) have a way to

RE : [PATCH] add PERL5LIB to @INC in the correct order

2003-10-18 Thread Ayhan Ulusoy
If I may add my grain of salt as an -interested- user for this one... Here's how I would expect PERL5LIB to work : 1) Ability to set it in httpd.conf on a per server, vhost, directory or location basis. 2) Ability to set it on a per request basis as well (via SetEnvIf or mod_rewrite) Wher

Re: Testing and smoking leave a PID file behind

2003-10-18 Thread Stas Bekman
Steve Hay wrote: [...] You did break one thing for sure: After your patch, the beginning of TestServer::start() looks like this: = my $self = shift; my $old_pid = -1; if (WIN32) { [...] if (-f $self->pid_file) { error "Removing old PID file -- " .

Re: [PATCH] Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Nicholas Clark
On Sat, Oct 18, 2003 at 10:20:35AM -0700, Stas Bekman wrote: > Rafael Garcia-Suarez wrote: > >And indeed this (tested) patch against mod_perl 1.99_10 fixes it. > > Thanks Rafael. In the future please post patches against the current cvs if > possible, as I've already applied a similar fix, thoug

Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Nicholas Clark
On Fri, Oct 17, 2003 at 12:41:04AM -0700, Stas Bekman wrote: > Seeing the rush of restoring some things as they were in 5.8.0 for 5.8.2, I > just thought that this could be one of the things that needs to be reverted > as well. Of course if the patch that we discussed does the trick, than it's >

Re: [PATCH] Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Stas Bekman
Rafael Garcia-Suarez wrote: Stas Bekman wrote: Though in your patch should we check for: #if PERL_REVISION == 5 && PERL_VERSION == 8 && PERL_SUBVERSION == 1 and higher and otherwise do nothing? Or do you think that checking for THREADS_HAVE_PIDS is enough? won't it be set as well in 5.6.x built

Re: [PATCH] Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Stas Bekman
Rafael Garcia-Suarez wrote: Stas Bekman wrote: Nicholas Clark wrote: On IRC Rafael said that he believes that his patch solves the problem without needing changes to perl. Is this the consensus view? Rafael's patch solves the problem in mod_perl 2.0. The problem still exists for any other applic

Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Stas Bekman
Nicholas Clark wrote: On Sat, Oct 18, 2003 at 11:17:39AM -0700, Stas Bekman wrote: Sorry Nick, I didn't imply any bad meaning by saying "rush". All I wanted to say is that since 5.8.2 is a maint release, it could fix problems in 5.8.1 which didn't exist in 5.8.0. It'll take awhile before people

Re: [PATCH] Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Rafael Garcia-Suarez
Stas Bekman wrote: > Nicholas Clark wrote: > > On IRC Rafael said that he believes that his patch solves the problem > > without needing changes to perl. Is this the consensus view? > > Rafael's patch solves the problem in mod_perl 2.0. The problem still exists > for any other application that em

Re: [PATCH] Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Rafael Garcia-Suarez
Stas Bekman wrote: > > Though in your patch should we check for: > > #if PERL_REVISION == 5 && PERL_VERSION == 8 && PERL_SUBVERSION == 1 > and higher and otherwise do nothing? Or do you think that checking for > THREADS_HAVE_PIDS is enough? won't it be set as well in 5.6.x built with threads? T

Re: [Patch] Apache::PerlSection(s?) rename

2003-10-18 Thread Stas Bekman
Philippe M. Chiasson wrote: Following patch renames Apache::PerlSection to Apache::PerlSections to fix the existing ambiguity between singular and plural PerlSection(s) +1 __ Stas BekmanJAm_pH --> Just Another mod_perl

Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Stas Bekman
Nicholas Clark wrote: On Fri, Oct 17, 2003 at 12:41:04AM -0700, Stas Bekman wrote: Seeing the rush of restoring some things as they were in 5.8.0 for 5.8.2, I just thought that this could be one of the things that needs to be reverted as well. Of course if the patch that we discussed does the tr

Re: [PATCH] Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Stas Bekman
Nicholas Clark wrote: On Sat, Oct 18, 2003 at 10:20:35AM -0700, Stas Bekman wrote: Rafael Garcia-Suarez wrote: And indeed this (tested) patch against mod_perl 1.99_10 fixes it. Thanks Rafael. In the future please post patches against the current cvs if possible, as I've already applied a simila

Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Stas Bekman
Rafael Garcia-Suarez wrote: Stas Bekman wrote: Well, the pid change is already out there in perl 5.8.1, so we need to make it more friendly for applications that embed perl on Linux. I think the fix should go both in blead and maint. Seeing the rush of restoring some things as they were in 5.8.0 f

Re: [PATCH] Re: [5.8.1] getppid is not maintained if not forked by perl

2003-10-18 Thread Stas Bekman
Rafael Garcia-Suarez wrote: Rafael Garcia-Suarez wrote: I don't think this happens on mod_perl 2 with prefork MPM, but I'm not sure why. Could someone try with mod_perl 2 / threaded or prefork MPM to see if the problem on $$ exists ? (Sorry, lacking time to test this myself now) I see that mod_per