Re: cvs commit: modperl-2.0/src/modules/perl modperl_env.c

2004-02-13 Thread Stefan Traby
On Sat, Feb 14, 2004 at 12:15:23AM -0500, Geoffrey Young wrote: > my thought is still that %ENV information like this is only relevant during > content-generation: you're obviously using mod_perl if you're running a > handler for any other phase. furthermore, I think it probably needs to > respec

functiontable

2004-02-13 Thread Randy Kobes
Hi, With some recent changes in the env stuff, an update to xs/tables/current/ModPerl/FunctionTable.pm is needed on Win32: = Index: xs/tables/current/ModPerl/FunctionTable.pm ==

Re: cvs commit: modperl-2.0/src/modules/perl modperl_env.c

2004-02-13 Thread Geoffrey Young
> move modperl_env_default_populate to where it was before (after > modperl_env_table_populate), so that GATEWAY_INTERFACE will be > CGI-Perl/1.1 and not CGI/1.1. whoops - I probably moved that at some point and didn't realize it. once we get the other issue sorted out, I'll specifically a

Re: cvs commit: modperl-2.0/src/modules/perl modperl_env.c

2004-02-13 Thread Geoffrey Young
> we still have a problem, which existed before the last env handling revamp. > > I think modules/cgi should work with this patch: > > Index: t/response/TestModules/cgi.pm > === > RCS file: /home/cvs/modperl-2.0/t/response/TestModul

Re: cvs commit: modperl-2.0/src/modules/perl modperl_env.c

2004-02-13 Thread Stas Bekman
[EMAIL PROTECTED] wrote: stas2004/02/13 20:50:32 Modified:src/modules/perl modperl_env.c Log: move modperl_env_default_populate to where it was before (after modperl_env_table_populate), so that GATEWAY_INTERFACE will be CGI-Perl/1.1 and not CGI/1.1. we still have a problem,

Re: [mp2] refactor perldo in modperl_cmd.c

2004-02-13 Thread Stas Bekman
Stas Bekman wrote: [...] +eval_pv(apr_psprintf(p, "{ local $0 = q[%s]; %s }", + directive->filename, arg), FALSE); I've figured that if the above works, why can't we do the same in C API. So I've digged in and learned that save_item doesn't handle magic. So here is a s

Re: [mp2] refactor perldo in modperl_cmd.c

2004-02-13 Thread Stas Bekman
Philippe M. Chiasson wrote: On Thu, 2004-02-12 at 14:03 -0800, Stas Bekman wrote: Philippe M. Chiasson wrote: On Wed, 2004-02-11 at 17:02 -0800, Stas Bekman wrote: Doesn't save_item completely copy the original sv away and then restore it on the scope exit? For some reason it doesn't work (fai

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: Boris Zentner wrote: [...] Right, but using Apache::Request is not so uncommon. May be A-R can be fixed to use a proper inheritance? Sorry I haven't been paying attention t

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Stas Bekman
I've extended lookup_method to support sub-classed objects. which simplifies the usage. It's now committed. Here is a test: perl -MModPerl::MethodLookup -le '\ package Apache::RequestRec; sub new { bless {}, shift }; \ package My::Request; @ISA = qw(Apache::RequestRec); \ package main; my $obj =

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Stefan Traby
On Fri, Feb 13, 2004 at 04:38:21PM -0500, Joe Schaefer wrote: > In mp2, Apache::RequestRec *is the base class* for A-R (A-R shouldn't > have any AUTOLOAD methods). AFAICT that certainly fits the bill as > being a necessity. How can a subclass be expected to work properly if > its parent modules

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > Joe Schaefer wrote: > > Stas Bekman <[EMAIL PROTECTED]> writes: > > > >>Boris Zentner wrote: > > [...] > > > >>>Right, but using Apache::Request is not so uncommon. > >> > >>May be A-R can be fixed to use a proper inheritance? > > Sorry I haven't been payi

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: Boris Zentner wrote: [...] Right, but using Apache::Request is not so uncommon. May be A-R can be fixed to use a proper inheritance? Sorry I haven't been paying attention to this thread. If by "proper inheritance" you mean, A-R sh

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > Boris Zentner wrote: [...] > > Right, but using Apache::Request is not so uncommon. > > May be A-R can be fixed to use a proper inheritance? Sorry I haven't been paying attention to this thread. If by "proper inheritance" you mean, A-R should require

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Stas Bekman
Boris Zentner wrote: Hi Stas, Am Freitag, 13. Februar 2004 04:17 schrieb Stas Bekman: Boris Zentner wrote: [...] 2. EazyLife can not know about my methods, so the option is guess and load all classes with methods that may satisfy me or ignore me. I dislike both and Apache::Request for

more Apache-Test sticky woes

2004-02-13 Thread Geoffrey Young
something is still amuck with the sticky preferences stuff. I ran $ perl Makefile.PL -apxs /apache/1.3/dso/perl-5.8.3/bin/apxs $ make && make test against a CPAN module, then tried to build mod_perl-2.0 $ make realclean $ perl Makefile.PL MP_APXS=/apache/2.0/worker/perl-5.8.3/bin/apxs $ make &&

Re: [mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-13 Thread Boris Zentner
Hi Stas, Am Freitag, 13. Februar 2004 04:17 schrieb Stas Bekman: > Boris Zentner wrote: [...] > > > > 2. EazyLife can not know about my methods, so the option is guess and > > load all classes with methods that may satisfy me or ignore me. I dislike > > both and Apache::Request forwards eve