Re: [mp2] error codes in the API?

2004-04-15 Thread Stas Bekman
Larry Leszczynski wrote: 1. use the right error message: $Apache::errstr $Apache::err $APR::errstr $APR::err I'd would have to lean toward preventing namespace pollution, so using ModPerl or MP doesn't feel right. Are all the error conditions truly generated only in APR routines? If so, I'd su

Re: [mp2] -- failing some tests

2004-04-15 Thread Stas Bekman
Ian Holsman wrote: these are the remaining errors t/filter/both_str_con_add.t43 75.00% 2-4 t/protocol/echo_filter.t 32 66.67% 2-3 These seem to be due to a bug/feature introduced in 2.0.49, which does nonblocking IO on the socket on several platforms

Re: [mp2] error codes in the API?

2004-04-15 Thread Larry Leszczynski
> 1. use the right error message: > > $Apache::errstr > $Apache::err > $APR::errstr > $APR::err I'd would have to lean toward preventing namespace pollution, so using ModPerl or MP doesn't feel right. Are all the error conditions truly generated only in APR routines? If so, I'd suggest: 1a.

Re: [mp2] -- failing some tests

2004-04-15 Thread Geoffrey Young
> The patch silences the error. > the only 'interesting' data point was that I have _13-dev running, (from > about a month or two ago) and this test didn't fail then. that's strange. can you track it down to any other factor? different perl, different apache, different kernel, etc? what is rea

Re: [mp2] -- failing some tests

2004-04-15 Thread Ian Holsman
Geoffrey Young wrote: # testing : $r->finfo->group() # expected: 4294967294 # received: -2 not ok 8 $ id ianh uid=501(ianh) gid=20(staff) groups=20(staff), 80(admin) ok, well if neither perl nor apr give the real answer then we have no choice but to simply sweep it under the carpet - in both c

Re: [mp2] error codes in the API?

2004-04-15 Thread Stas Bekman
Render Web wrote: Stas Bekman wrote: 3. use just one set /$ModPerl::err(str)?/ 4. use one set and shortcut it to /$MP::err(str)?/ How about MP2? I do not wnat to raise the MP1/2/3 debate again but I never saw a yay/nay decision :-) The argument against numbers in the package names is the same,

Re: [mp2] error codes in the API?

2004-04-15 Thread Stas Bekman
Geoffrey Young wrote: 2. make the two interchangable via aliasing, so setting /$Apache::err(str)?/ will also set /$APR::err(str)?/ that's still my favorite if we can swing it. I'm not sure about it. so let's say we create the alias, people get used to use $Apache::err everywhere, so we end up wi

Re: [mp2] error codes in the API?

2004-04-15 Thread Render Web
Stas Bekman wrote: 3. use just one set /$ModPerl::err(str)?/ 4. use one set and shortcut it to /$MP::err(str)?/ How about MP2? I do not wnat to raise the MP1/2/3 debate again but I never saw a yay/nay decision :-) So speak up before we started to change everything, tell which one do you like and