Re: [mp2] map to storage handler

2004-06-08 Thread Geoffrey Young
> that's right - if you are implementing a PerlMapToStorageHandler then you > are in charge of handling all the logic that is required of core if you > return OK. this is exactly the same as it used to be with the > PerlTransHandler - return OK and you better be sure that you set > $r->filename t

Re: [mp2] map to storage handler

2004-06-08 Thread Geoffrey Young
> 3) and there is ap_send_http_trace in http_protocol.c, registered as: > ap_hook_map_to_storage(ap_send_http_trace,NULL,NULL,APR_HOOK_MIDDLE); > > > > So we have a problem here. If one uses PerlMapToStorageHandler to > shortcut the uri2file translation, and returns OK, TRACE calls will be > no

[mp2] map to storage handler

2004-06-08 Thread Stas Bekman
I'm trying to work on the map to storage example. Here is what we have now: 1) From httpd-2.0/CHANGES: *) Introduce the map_to_storage hook, which allows modules to bypass the directory_walk and file_walk for non-file requests. TRACE shortcut moved to http_protocol.c as APR_HOOK_MIDDLE

Re: [mp2] one more pass on mp2/apr read() functions

2004-06-08 Thread Stas Bekman
It makes the socket read/write loops similar to filter ones: while ($socket->recv(my $buff, BUFF_LEN)) { $socket->send($buff); } Here is the whole patch: Index: lib/Apache/compat.pm === RCS file: /home/cvs/modperl-2.0/l

Re: [mp2] one more pass on mp2/apr read() functions

2004-06-08 Thread Stas Bekman
Stas Bekman wrote: I'm doing yet another tweak on the read() API to make things really consistent: So now we (will) have the following read functions: - APR::Socket: $len = $socket->read(my $buffer); - APR::Bucket: $len = $bucket->read(my $buffer); - APR::Filter: $len = $filter->read(my $buffer);

[mp2] one more pass on mp2/apr read() functions

2004-06-08 Thread Stas Bekman
I'm doing yet another tweak on the read() API to make things really consistent: So now we (will) have the following read functions: - APR::Socket: $len = $socket->read(my $buffer); - APR::Bucket: $len = $bucket->read(my $buffer); - APR::Filter: $len = $filter->read(my $buffer); (plus all the option

Re: cvs commit: modperl-2.0/t/protocol/TestProtocol echo_block.pm echo_timeout.pm

2004-06-08 Thread Stas Bekman
Geoffrey Young wrote: e.g.: % cvs co -D 20040601 -d mp2-20040601 modperl-2.0 yeah, I can try when I get the time (heh). but it might not be mod_perl's fault so I'll really need to do an httpd regression as well. OK. Either way it's better to get the bugs fixed while they are hot :) --

Re: cvs commit: modperl-2.0/t/protocol/TestProtocol echo_block.pm echo_timeout.pm

2004-06-08 Thread Geoffrey Young
> e.g.: > % cvs co -D 20040601 -d mp2-20040601 modperl-2.0 yeah, I can try when I get the time (heh). but it might not be mod_perl's fault so I'll really need to do an httpd regression as well. --Geoff - To unsubscribe, e-mail:

Re: cvs commit: modperl-2.0/t/protocol/TestProtocol echo_block.pm echo_timeout.pm

2004-06-08 Thread Stas Bekman
Geoffrey Young wrote: Are you sure this is because of this last change? I haven't really changed much. If you revert it, does it work ok? no, it wasn't due to the last change in echo_timeout.pm - I was just searching for the most recent change to respond to :) but it is something fairly recent - m

Re: cvs commit: modperl-2.0/t/protocol/TestProtocol echo_block.pm echo_timeout.pm

2004-06-08 Thread Geoffrey Young
> Are you sure this is because of this last change? I haven't really > changed much. If you revert it, does it work ok? no, it wasn't due to the last change in echo_timeout.pm - I was just searching for the most recent change to respond to :) but it is something fairly recent - my nightly builds

Re: cvs commit: modperl-2.0/t/protocol/TestProtocol echo_block.pm echo_timeout.pm

2004-06-08 Thread Stas Bekman
Geoffrey Young wrote: [EMAIL PROTECTED] wrote: stas2004/06/03 01:22:21 Modified:t/filter/TestFilter both_str_con_add.pm t/protocol/TestProtocol echo_block.pm echo_timeout.pm Log: - apparently setting to a blocking IO is not going to be a workaround but a requirement, s