Re: adding APR::Status?

2005-04-18 Thread Nick ***
Philip M. Gollucci wrote: > > +static MP_INLINE int mpxs_APR__STATUS_is_eagain(pTHX_ apr_status_t rc) > > +{ > > + return APR_STATUS_IS_EAGAIN(rc) ? TRUE : FALSE; > > +} > > Based on Nicks previous CYGWIN patch... > > shouldn't that be MP_STATIC and not static ? No, it shouldn't -

Re: adding APR::Status?

2005-04-18 Thread Randy Kobes
On Mon, 18 Apr 2005, Stas Bekman wrote: > Randy Kobes wrote: > > In the discussion of a failure on Win32 of t/error/runtime > > at http://marc.theaimsgroup.com/?t=11121785691&r=1&w=2, > > Stas suggested adding an APR::Status, containing things like > > APR_STATUS_IS_EAGAIN(s) from apr_errno.h.

Re: adding APR::Status?

2005-04-18 Thread Stas Bekman
Philip M. Gollucci wrote: > +static MP_INLINE int mpxs_APR__STATUS_is_eagain(pTHX_ apr_status_t rc) > +{ > +return APR_STATUS_IS_EAGAIN(rc) ? TRUE : FALSE; > +} Based on Nicks previous CYGWIN patch... shouldn't that be MP_STATIC and not static ? If it's a macro, it becomes irrelevant :) --

Re: adding APR::Status?

2005-04-18 Thread Philip M. Gollucci
> +static MP_INLINE int mpxs_APR__STATUS_is_eagain(pTHX_ apr_status_t rc) > +{ > +return APR_STATUS_IS_EAGAIN(rc) ? TRUE : FALSE; > +} Based on Nicks previous CYGWIN patch... shouldn't that be MP_STATIC and not static ? -- END

Re: adding APR::Status?

2005-04-18 Thread Stas Bekman
Randy Kobes wrote: In the discussion of a failure on Win32 of t/error/runtime at http://marc.theaimsgroup.com/?t=11121785691&r=1&w=2, Stas suggested adding an APR::Status, containing things like APR_STATUS_IS_EAGAIN(s) from apr_errno.h. I've attached a patch against the current mp2 svn implemen

Re: Apache2->request in Apache::SizeLimit

2005-04-18 Thread Geoffrey Young
Randy Kobes wrote: > In the current mp2 svn, Apache::SizeLimit uses > Apache2->request blarg. > - should that be > Apache2::RequestUtil->request? probably :) --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additiona

Re: building mp2 with a prior install

2005-04-18 Thread Geoffrey Young
> - if this problem arises just because an old Apache2.pm is > still there, and nothing else, perhaps Makefile.PL should > abort if it finds Apache2.pm? The above error message > doesn't really suggest what's causing the problem. that was my original intent, but I guess the Makefile.PL code migra