Re: [suggestion] Change branching instructions to use svnmerge

2007-10-11 Thread Randy Kobes
On Wed, 10 Oct 2007, Fred Moyer wrote: Philippe M. Chiasson wrote: In preparing for creating a branch for Torsten's threading work, I looked at our BRANCHING document, and it's associated script build/svn.remerge. Instead, I'd like to push forward a great svn merge tool, svnmerge[1] +1 +1

Re: possible pnotes refcounting bug ?

2007-10-11 Thread Geoffrey Young
Torsten Foertsch wrote: > On Thursday 11 October 2007 15:18, Torsten Foertsch wrote: >> if (key) { >> STRLEN len; >> char *k = SvPV(key, len); >> >> if (val) { >> retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0); >> } >> else if (hv

Re: possible pnotes refcounting bug ?

2007-10-11 Thread Torsten Foertsch
On Thursday 11 October 2007 15:18, Torsten Foertsch wrote: > if (key) { > STRLEN len; > char *k = SvPV(key, len); > > if (val) { > retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0); > } > else if (hv_exists(*pnotes, k, len)) { >

Re: possible pnotes refcounting bug ?

2007-10-11 Thread Geoffrey Young
Torsten Foertsch wrote: > Hi, > > this is a snippet from modperl_util.c:modperl_pnotes() > > if (key) { > STRLEN len; > char *k = SvPV(key, len); > > if (val) { > retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0); > } > else if (h

possible pnotes refcounting bug ?

2007-10-11 Thread Torsten Foertsch
Hi, this is a snippet from modperl_util.c:modperl_pnotes() if (key) { STRLEN len; char *k = SvPV(key, len); if (val) { retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0); } else if (hv_exists(*pnotes, k, len)) { retval =

Re: Please help adding ModPerl::Interpreter

2007-10-11 Thread Torsten Foertsch
On Wednesday 10 October 2007 21:20, Philippe M. Chiasson wrote: > The only question I have is wherever it's necessary to also expose the > following 2 items: > > modperl_interp_pool_t * | IV > PerlInterpreter *       | IV > > Especially in the current patch, what you get out will pretty much > be a