Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Philippe M. Chiasson
Torsten Foertsch wrote: > On Thursday 18 October 2007, Philippe M. Chiasson wrote: >> Any chance you can break the patch into multiple patches > > This one removes the unused tipool_cfg from modperl_interp_pool_t. Already applied to the trunk/ as r585724 -

Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Philippe M. Chiasson
Torsten Foertsch wrote: > On Thursday 18 October 2007, Philippe M. Chiasson wrote: >> Any chance you can break the patch into multiple patches > > This one is supposed to be applied after the pid-tid patch to the threading > branch. It adds the last pnotes refcount fix. It's already been applied

Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Torsten Foertsch
On Thursday 18 October 2007, Philippe M. Chiasson wrote: > Any chance you can break the patch into multiple patches This one adds ModPerl::InterpPool, ModPerl::TiPool and ModPerl::TiPoolConfig, changes ModPerl::Interpreter a bit and provides some basic testing. Torsten Index: xs/maps/modperl_str

Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Torsten Foertsch
On Wednesday 24 October 2007, Torsten Foertsch wrote: > On Thursday 18 October 2007, Philippe M. Chiasson wrote: > > Any chance you can break the patch into multiple patches > > This one ... I forgot the changes in xs/maps and xs/tables. Torsten Index: src/modules/perl/modperl_types.h ===

Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Torsten Foertsch
On Thursday 18 October 2007, Philippe M. Chiasson wrote: > Any chance you can break the patch into multiple patches This one makes PerlInterpScope more advisory. Using pnotes increment the refcnt of the interp thus binding it to the lifetime of the pnotes. So, using $c->pnotes binds the interp t

Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Torsten Foertsch
On Thursday 18 October 2007, Philippe M. Chiasson wrote: > Any chance you can break the patch into multiple patches This one registers the cleanup phase with a subpool to ensure it is run before pnotes are destroyed. Subpools are destroyed first thing in apr_pool_{clear,destroy}. Hence, a pool c

Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Torsten Foertsch
On Wednesday 24 October 2007, Torsten Foertsch wrote: > This one ... Ups, forgot to add t/directive/perlcleanuphandler.t Torsten Index: src/modules/perl/mod_perl.c === --- src/modules/perl/mod_perl.c (revision 4) +++ src/modules/perl

Re: Please help adding ModPerl::Interpreter

2007-10-24 Thread Torsten Foertsch
On Thursday 18 October 2007, Philippe M. Chiasson wrote: > Any chance you can break the patch into multiple patches This one needs the refcount based interpreter management to work. It moves the registration of the PerlCleanupHandler callback to modperl_hook_create_request. It also fixes a prob