about removing the last hash lookup in the interp management code

2007-11-14 Thread Torsten Foertsch
Hi Philippe, in the threading branch this line and the corresponding get in modperl_interp_pool_select() are the last occurrences of hash lookups in the interp management. (void)apr_pool_userdata_set((void *)r, "MODPERL_R", NULL, r->pool); I am thinking of removing it. But it requires a

Re: Please help adding ModPerl::Interpreter

2007-11-14 Thread Philippe M. Chiasson
Torsten Foertsch wrote: > Hi Philippe, > > I am glad to see that all my patches are now applied to the threading branch. > The tweaks you have mentioned are only related to tab-based indentation, > right? That's the nice thing about a hackathon ;-) Yup, mostly just juggling whitespace around.

Re: Please help adding ModPerl::Interpreter

2007-11-14 Thread Torsten Foertsch
Hi Philippe, I am glad to see that all my patches are now applied to the threading branch. The tweaks you have mentioned are only related to tab-based indentation, right? I have noticed that you have also deleted some trailing newlines on MP_TRACEs. Most MP_TRACE_x invocations have trailing ne