Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: So, I guess I should just go ahead with my band-aid fix and we can worry about the _real_ problem later then? +1 Band-aid applied! -- Philippe M. Chiasson m/gozer\@(apa

Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Stas Bekman
Philippe M. Chiasson wrote: So, I guess I should just go ahead with my band-aid fix and we can worry about the _real_ problem later then? +1 -- __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/

Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Philippe M. Chiasson
Geoffrey Young wrote: Geoffrey Young wrote: Before I go ahead and check that in, I'd like to at least get a bit more feedback from the other folks that had been seeing this segfault, and confirmation that this patch _does_ get rid of it. I'll give it a whirl tonight. whee! all tests pass. Good,

Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Geoffrey Young
Geoffrey Young wrote: >>Before I go ahead and check that in, I'd like to at least get a bit more >>feedback from the other folks that had been seeing this segfault, and >>confirmation that this patch _does_ get rid of it. > > > I'll give it a whirl tonight. whee! all tests pass. nice work.

Re: [Patch mp2] segfault in worker mpm

2004-10-13 Thread Geoffrey Young
>> I'll give it a whirl tonight. in truth, though, I forget exactly the >> conditions that were causing it - I'm seeing a segfault now with >> 2.0.47 (and >> not 2.0.52) worker in the filter tests that is not reproducable when they >> are run on their own. > > > What filter test were failing ?

Re: [Patch mp2] segfault in worker mpm

2004-10-13 Thread Philippe M. Chiasson
Geoffrey Young wrote: Before I go ahead and check that in, I'd like to at least get a bit more feedback from the other folks that had been seeing this segfault, and confirmation that this patch _does_ get rid of it. I'll give it a whirl tonight. in truth, though, I forget exactly the conditions

Re: [Patch mp2] segfault in worker mpm

2004-10-13 Thread Geoffrey Young
> Before I go ahead and check that in, I'd like to at least get a bit more > feedback from the other folks that had been seeing this segfault, and > confirmation that this patch _does_ get rid of it. I'll give it a whirl tonight. in truth, though, I forget exactly the conditions that were causin

Re: [Patch mp2] segfault in worker mpm

2004-10-13 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: I spent quite a lot of time trying to figure out the root cause of this problem without much success. There is some strange interaction with Perl_load_module() that's causing this segfault. I've rewritten that part to use eval_sv() instead and the

Re: [Patch mp2] segfault in worker mpm

2004-10-12 Thread Stas Bekman
Philippe M. Chiasson wrote: I spent quite a lot of time trying to figure out the root cause of this problem without much success. There is some strange interaction with Perl_load_module() that's causing this segfault. I've rewritten that part to use eval_sv() instead and the segfault vanished f

[Patch mp2] segfault in worker mpm

2004-10-12 Thread Philippe M. Chiasson
I spent quite a lot of time trying to figure out the root cause of this problem without much success. There is some strange interaction with Perl_load_module() that's causing this segfault. I've rewritten that part to use eval_sv() instead and the segfault vanished for me. As much as I'd like to na