Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Stas Bekman
Philippe M. Chiasson wrote: On Thu, 2003-05-29 at 15:39, Stas Bekman wrote: Philippe M. Chiasson wrote: On Thu, 2003-05-29 at 15:14, Stas Bekman wrote: I'm not sure why that code was there. So I'm not so confident on removing it. mp1's test suite is too poor for regression testing. Yeah, you

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Philippe M. Chiasson
On Thu, 2003-05-29 at 15:39, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Thu, 2003-05-29 at 15:14, Stas Bekman wrote: > > > I'm not sure why that code was there. So I'm not so confident on removing it. > mp1's test suite is too poor for regression testing. > >>> > >>> > >>>Yea

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Stas Bekman
Philippe M. Chiasson wrote: On Thu, 2003-05-29 at 15:14, Stas Bekman wrote: I'm not sure why that code was there. So I'm not so confident on removing it. mp1's test suite is too poor for regression testing. Yeah, you can say that again. I dunno if it would be eventually worth it to port mp1's t

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Philippe M. Chiasson
On Thu, 2003-05-29 at 15:14, Stas Bekman wrote: > >>I'm not sure why that code was there. So I'm not so confident on removing it. > >>mp1's test suite is too poor for regression testing. > > > > > > Yeah, you can say that again. I dunno if it would be eventually worth it > > to port mp1's tests

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Stas Bekman
I'm not sure why that code was there. So I'm not so confident on removing it. mp1's test suite is too poor for regression testing. Yeah, you can say that again. I dunno if it would be eventually worth it to port mp1's tests to Apache::Test and try and achieve better covereage. But once again, h

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Philippe M. Chiasson
On Thu, 2003-05-29 at 12:09, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Thu, 2003-05-29 at 07:13, Stas Bekman wrote: > > > >>Geoffrey Young wrote: > >> > The problem pointed out by Ken is that it would be nice to be able to > call > > Apache->request($hr); > > >>

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Stas Bekman
Philippe M. Chiasson wrote: On Thu, 2003-05-29 at 07:13, Stas Bekman wrote: Geoffrey Young wrote: The problem pointed out by Ken is that it would be nice to be able to call Apache->request($hr); So that later call to Apache->request (by other modules) would return the subclassed object. it wou

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Philippe M. Chiasson
On Thu, 2003-05-29 at 07:13, Stas Bekman wrote: > Geoffrey Young wrote: > > > >> The problem pointed out by Ken is that it would be nice to be able to > >> call > >> > >> Apache->request($hr); > >> > >> So that later call to Apache->request (by other modules) would > >> return the subclassed objec

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Philippe M. Chiasson
On Thu, 2003-05-29 at 03:56, Geoffrey Young wrote: > > The problem pointed out by Ken is that it would be nice to be able to > > call > > > > Apache->request($hr); > > > > So that later call to Apache->request (by other modules) would > > return the subclassed object. > > it would not only be ni

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Stas Bekman
Geoffrey Young wrote: The problem pointed out by Ken is that it would be nice to be able to call Apache->request($hr); So that later call to Apache->request (by other modules) would return the subclassed object. it would not only be nice, request() is documented to behave this way :) Well, the

Re: [mp1 Patch] Looking for magic in Apache->request

2003-05-29 Thread Geoffrey Young
The problem pointed out by Ken is that it would be nice to be able to call Apache->request($hr); So that later call to Apache->request (by other modules) would return the subclassed object. it would not only be nice, request() is documented to behave this way :) Well, the following patch does ju

[mp1 Patch] Looking for magic in Apache->request

2003-05-28 Thread Philippe M. Chiasson
28 May 2003 12:53:54 - @@ -55,7 +55,6 @@ sub handler { my($r) = @_; -Apache->request($r); #for Apache::CGI my $qs = $r->args || ""; my $sub = "status_$qs"; no strict 'refs'; > > -----Original Message- > > From: Doug

RE: Looking for magic in Apache->request

2001-08-08 Thread Geoffrey Young
hi Doug... just wondering if this item is still on your radar? --Geoff > -Original Message- > From: Doug MacEachern [mailto:[EMAIL PROTECTED]] > Sent: Monday, April 02, 2001 12:51 AM > To: Ken Williams > Cc: [EMAIL PROTECTED] > Subject: Re: Looking for magic

Re: Looking for magic in Apache->request

2001-04-01 Thread Doug MacEachern
On Fri, 30 Mar 2001, Ken Williams wrote: > The thing I can't figure out from the XS code is how/where > Apache->request calls sv2request_rec(), which actually does the > extraction work. Somehow it's automatically converted, because I see no > manual conversion in the Apache->request code below

Re: Looking for magic in Apache->request

2001-04-01 Thread Matt Sergeant
On Sun, 1 Apr 2001, Ken Williams wrote: > Dang. So that would mean that in order to fix this, Apache->request($r) > would have to accept an arbitrary scalar, not something automatically > converted to an Apache object, right? Right. > And then there's the matter of how it should be stored...

Re: Looking for magic in Apache->request

2001-04-01 Thread Ken Williams
[EMAIL PROTECTED] (Matt Sergeant) wrote: >On Fri, 30 Mar 2001, Ken Williams wrote: > >> The thing I can't figure out from the XS code is how/where >> Apache->request calls sv2request_rec(), which actually does the >> extraction work. Somehow it's automatically converted, because I see no >> manua

Re: Looking for magic in Apache->request

2001-03-31 Thread Matt Sergeant
On Fri, 30 Mar 2001, Ken Williams wrote: > The thing I can't figure out from the XS code is how/where > Apache->request calls sv2request_rec(), which actually does the > extraction work. Somehow it's automatically converted, because I see no > manual conversion in the Apache->request code below:

Looking for magic in Apache->request

2001-03-30 Thread Ken Williams
Hi, Consider the following code under mod_perl (current CVS 1.25): # Get the original request object my $r = Apache->request; $r->send_http_header('text/html'); # Subclass Apache and install new $r my $r2 = bless {'_r' => $r}, 'OtherPackage'; @OtherPackage::ISA = ('Apache');