Torsten Foertsch wrote:
> On Wed 14 Nov 2007, Philippe M. Chiasson wrote:
>>> I have noticed that you have also deleted some trailing newlines on
>>> MP_TRACEs. Most MP_TRACE_x invocations have trailing newlines. For me
>>> they are rather disturbing but I thought they were there on purpose. So,
>>
Torsten Foertsch wrote:
> Hi Philippe,
>
> On Thu 25 Oct 2007, Torsten Foertsch wrote:
>> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>>> Any chance you can break the patch into multiple patches
>> This is the last one of this series of patches. It simply adds the test
>> perl/ithread
Hi Philippe,
On Thu 25 Oct 2007, Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> > Any chance you can break the patch into multiple patches
>
> This is the last one of this series of patches. It simply adds the test
> perl/ithreads3.
>
> Please apply all these
Torsten Foertsch wrote:
> Hi Philippe,
>
> I am glad to see that all my patches are now applied to the threading branch.
> The tweaks you have mentioned are only related to tab-based indentation,
> right?
That's the nice thing about a hackathon ;-)
Yup, mostly just juggling whitespace around.
Hi Philippe,
I am glad to see that all my patches are now applied to the threading branch.
The tweaks you have mentioned are only related to tab-based indentation,
right?
I have noticed that you have also deleted some trailing newlines on MP_TRACEs.
Most MP_TRACE_x invocations have trailing ne
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one makes PerlInterpScope more advisory. Using pnotes increment the
> refcnt of the interp thus binding it to the lifetime of the pnotes. So, usi
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one needs the refcount based interpreter management to work. It moves
> the
> registration of the PerlCleanupHandler callback to
> modperl_hook
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one implements the refcount based interpreter management. Is supposed to
> be applied on top of the pnotes-refcount patch.
>
> It implements bas
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one adds ModPerl::InterpPool, ModPerl::TiPool and ModPerl::TiPoolConfig,
> changes ModPerl::Interpreter a bit and provides some basic testing.
C
Torsten Foertsch wrote:
> On Monday 22 October 2007, Philippe M. Chiasson wrote:
>> And make modperl_trace always prefix log messages with modperl_tid_pid()?
>
> That makes sense. I didn't know about modperl_pid_tid(). But the
> implementation is not good.
>
> 1) It requires a pool that is not a
On Thursday 25 October 2007, Philippe M. Chiasson wrote:
> > It was named after apr_pool_cleanup_kill(). If you don't like it then
> > what do you prefer _destroy or _reset? To me it's all the same.
>
> In that case, yes, pnotes_kill() probably is a bit more consistent.
>
> Of course, after thinkin
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This is the last one of this series of patches. It simply adds the test
perl/ithreads3.
Please apply all these patches in the given order to the threading branch.
The result compi
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>>> The patch contains all my findings so far including the pnotes refcount
>>> problem. Pnotes now lock the interpreter like pools do.
>> Any chance you can break the patch into multiple patches, one for each
>> fea
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one registers the cleanup phase with a subpool to ensure it is run
> before
> pnotes are destroyed. Subpools are destroyed first thing in
> apr
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one removes the unused tipool_cfg from modperl_interp_pool_t.
Already applied to the trunk/ as r585724
-
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one is supposed to be applied after the pid-tid patch to the threading
> branch. It adds the last pnotes refcount fix.
It's already been applied
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one adds ModPerl::InterpPool, ModPerl::TiPool and ModPerl::TiPoolConfig,
changes ModPerl::Interpreter a bit and provides some basic testing.
Torsten
Index: xs/maps/modperl_str
On Wednesday 24 October 2007, Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> > Any chance you can break the patch into multiple patches
>
> This one ...
I forgot the changes in xs/maps and xs/tables.
Torsten
Index: src/modules/perl/modperl_types.h
===
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one makes PerlInterpScope more advisory. Using pnotes increment the
refcnt of the interp thus binding it to the lifetime of the pnotes. So, using
$c->pnotes binds the interp t
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one registers the cleanup phase with a subpool to ensure it is run before
pnotes are destroyed. Subpools are destroyed first thing in
apr_pool_{clear,destroy}. Hence, a pool c
On Wednesday 24 October 2007, Torsten Foertsch wrote:
> This one ...
Ups, forgot to add t/directive/perlcleanuphandler.t
Torsten
Index: src/modules/perl/mod_perl.c
===
--- src/modules/perl/mod_perl.c (revision 4)
+++ src/modules/perl
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one needs the refcount based interpreter management to work. It moves the
registration of the PerlCleanupHandler callback to
modperl_hook_create_request.
It also fixes a prob
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one removes the unused tipool_cfg from modperl_interp_pool_t.
Torsten
Index: src/modules/perl/modperl_types.h
==
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one implements the refcount based interpreter management. Is supposed to
be applied on top of the pnotes-refcount patch.
It implements basically the same functionality as the
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one is supposed to be applied after the pid-tid patch to the threading
branch. It adds the last pnotes refcount fix.
Torsten
Index: src/modules/perl/modperl_util.c
===
On Monday 22 October 2007, Philippe M. Chiasson wrote:
> And make modperl_trace always prefix log messages with modperl_tid_pid()?
That makes sense. I didn't know about modperl_pid_tid(). But the
implementation is not good.
1) It requires a pool that is not always available
2) It introduces a me
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
>
> This one adds the current pid to the output of modperl_trace.
Wouldn't a better all-around approach use a pid/tid combination for
threaded MPMs and fa
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> Any chance you can break the patch into multiple patches
This one adds the current pid to the output of modperl_trace.
Torsten
Index: src/modules/perl/modperl_common_log.c
==
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
> > The patch contains all my findings so far including the pnotes refcount
> > problem. Pnotes now lock the interpreter like pools do.
>
> Any chance you can break the patch into multiple patches, one for each
> feature/fix? Ideally with an
Torsten Foertsch wrote:
> On Saturday 13 October 2007 08:31, Philippe M. Chiasson wrote:
>> In the meantime, I've created a threading branch here:
>>
>> http://svn.apache.org/repos/asf/perl/modperl/branches/threading
>>
>> And I've applied this change (rev 584377) as the first one in hopefully
>> m
Torsten Foertsch wrote:
> On Wednesday 10 October 2007 21:20, Philippe M. Chiasson wrote:
>> The only question I have is wherever it's necessary to also expose the
>> following 2 items:
>>
>> modperl_interp_pool_t * | IV
>> PerlInterpreter * | IV
>>
>> Especially in the current patch, what yo
On Wednesday 10 October 2007 21:20, Philippe M. Chiasson wrote:
> The only question I have is wherever it's necessary to also expose the
> following 2 items:
>
> modperl_interp_pool_t * | IV
> PerlInterpreter * | IV
>
> Especially in the current patch, what you get out will pretty much
> be a
Torsten Foertsch wrote:
> Hi Geoff,
>
> On Tuesday 09 October 2007 19:19, Geoffrey Young wrote:
>> if you're really confused, see the commits when I added Apache::MPM
>>
>> http://marc.info/?l=apache-modperl-cvs&m=106978727408877&w=2
>> http://marc.info/?l=apache-modperl-cvs&m=106978912311523&
Torsten Foertsch wrote:
> Hi Geoff,
>
> On Tuesday 09 October 2007 19:19, Geoffrey Young wrote:
>> if you're really confused, see the commits when I added Apache::MPM
>>
>> http://marc.info/?l=apache-modperl-cvs&m=106978727408877&w=2
>> http://marc.info/?l=apache-modperl-cvs&m=10697891231152
Hi Geoff,
On Tuesday 09 October 2007 19:19, Geoffrey Young wrote:
> if you're really confused, see the commits when I added Apache::MPM
>
> http://marc.info/?l=apache-modperl-cvs&m=106978727408877&w=2
> http://marc.info/?l=apache-modperl-cvs&m=106978912311523&w=2
>
> the bulk of the main commi
Torsten Foertsch wrote:
> Hi,
>
> for testing purposes I need an interface to the modperl_interp_t. That means
> I'd like to check the current interp's refcnt and num_requests members from
> perl level.
>
> So I thought of adding a ModPerl::Interpreter XS module. But after reading
> http://p
Hi,
for testing purposes I need an interface to the modperl_interp_t. That means
I'd like to check the current interp's refcnt and num_requests members from
perl level.
So I thought of adding a ModPerl::Interpreter XS module. But after reading
http://perl.apache.org/docs/2.0/devel/core/explain
37 matches
Mail list logo
