Re: [PATCH] prototypes/constant redefinition warnings from ModPerl::Util

2009-01-07 Thread Philippe M. Chiasson
On 6/11/08 15:39, Casey West wrote: Hi, Apache2::Reload relies on ModPerl::Util::unload_package_pp to disassemble a stash entry before importing the code again. I like how it does this with two exceptions. Thanks. First, prototypes. unload_package_pp() takes care to retain the prototype when

Re: [PATCH] prototypes/constant redefinition warnings from ModPerl::Util

2008-11-12 Thread Geoffrey Young
Casey West wrote: > On Sat, Nov 8, 2008 at 8:55 PM, Geoffrey Young > <[EMAIL PROTECTED]> wrote: >> Geoffrey Young wrote: >>> -undef &$fullname; >>> +delete ${$fullname}{CODE}; >>> >>> I swear there is some p5p history here that treats that slot differently >>> when it's un

Re: [PATCH] prototypes/constant redefinition warnings from ModPerl::Util

2008-11-10 Thread Casey West
On Sat, Nov 8, 2008 at 8:55 PM, Geoffrey Young <[EMAIL PROTECTED]> wrote: > Geoffrey Young wrote: >> >> -undef &$fullname; >> +delete ${$fullname}{CODE}; >> >> I swear there is some p5p history here that treats that slot differently >> when it's undef versus exists. IIRC an

Re: [PATCH] prototypes/constant redefinition warnings from ModPerl::Util

2008-11-08 Thread Geoffrey Young
Geoffrey Young wrote: > > -undef &$fullname; > +delete ${$fullname}{CODE}; > > I swear there is some p5p history here that treats that slot differently > when it's undef versus exists. IIRC an early 5.8.0 iteration broke > mod_perl because of exactly this (or, if you pr

Re: [PATCH] prototypes/constant redefinition warnings from ModPerl::Util

2008-11-08 Thread Geoffrey Young
-undef &$fullname; +delete ${$fullname}{CODE}; I swear there is some p5p history here that treats that slot differently when it's undef versus exists. IIRC an early 5.8.0 iteration broke mod_perl because of exactly this (or, if you prefer, mod_perl exposed a feature of p