Re: TestServer::start_gdb

2001-07-19 Thread Stas Bekman
On Thu, 19 Jul 2001, Doug MacEachern wrote: > looks great stas, feel free to commit. > there's just one style nit > if () { > } else { > } > which should be: > if () { > else { > } doh! habits, habits I'd install per-commit filter to croak on the '} else {' pattern :) thanks for reminder

Re: TestServer::start_gdb

2001-07-19 Thread Doug MacEachern
looks great stas, feel free to commit. there's just one style nit if () { } else { } which should be: if () { else { } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: TestServer::start_gdb

2001-07-19 Thread Stas Bekman
the previous patch had a flow :( (always started gdb) here is a correct one: Index: Apache-Test/lib/Apache/TestRun.pm === RCS file: /home/cvs/modperl-2.0/Apache-Test/lib/Apache/TestRun.pm,v retrieving revision 1.10 diff -u -r1.10 Te

Re: TestServer::start_gdb

2001-07-19 Thread Stas Bekman
On Wed, 18 Jul 2001, Doug MacEachern wrote: > On Thu, 19 Jul 2001, Stas Bekman wrote: > > > now -debug will always set the apr_dso_load and modperl_hook_init bp and > > run after these. > > i think you misunderstood my comment before. no breakpoints should > be set by default, only when -breakpo

Re: TestServer::start_gdb

2001-07-18 Thread Doug MacEachern
On Thu, 19 Jul 2001, Stas Bekman wrote: > now -debug will always set the apr_dso_load and modperl_hook_init bp and > run after these. i think you misunderstood my comment before. no breakpoints should be set by default, only when -breakpoint is specified. and rather than using apr_dso_load to

Re: TestServer::start_gdb

2001-07-18 Thread Stas Bekman
This patch adds the following features: -- now -debug will always set the apr_dso_load and modperl_hook_init bp and run after these. -- run with the defaults: gdb % ./t/TEST -debug or use ddd (and later on some other debuggers): % ./t/TEST -debug[=]ddd Note that currently I tel

Re: TestServer::start_gdb

2001-07-15 Thread Stas Bekman
On Sun, 15 Jul 2001, Doug MacEachern wrote: > On Sat, 14 Jul 2001, Stas Bekman wrote: > > > doable. I know you don't want to lose -d shortcut :) > > yeah :) > > > I'm not sure what's the definition of 'always'. There are cases where you > > run -d to debug the segfault and you want the debugger t

Re: TestServer::start_gdb

2001-07-15 Thread Doug MacEachern
On Sat, 14 Jul 2001, Stas Bekman wrote: > doable. I know you don't want to lose -d shortcut :) yeah :) > I'm not sure what's the definition of 'always'. There are cases where you > run -d to debug the segfault and you want the debugger to 'run' till the > segfault without any breakpoints. Whe

Re: TestServer::start_gdb

2001-07-13 Thread Stas Bekman
On Fri, 13 Jul 2001, Doug MacEachern wrote: > On Wed, 11 Jul 2001, Stas Bekman wrote: > > > % ./t/TEST -debug -debugger=ddd > > how about reusing the current -debug: t/TEST -d ddd ? doable. I know you don't want to lose -d shortcut :) > > --debug-hook_init : bring the debugger to the 'modperl

Re: TestServer::start_gdb

2001-07-13 Thread Doug MacEachern
On Wed, 11 Jul 2001, Stas Bekman wrote: > % ./t/TEST -debug -debugger=ddd how about reusing the current -debug: t/TEST -d ddd ? > --debug-hook_init : bring the debugger to the 'modperl_hook_init' > function via the breakpoint (internally it first loads the mod_perl > DSO module via 'apr_dso_

Re: TestServer::start_gdb

2001-07-10 Thread Stas Bekman
On Mon, 9 Jul 2001, Doug MacEachern wrote: > On Sun, 8 Jul 2001, Stas Bekman wrote: > > > > > Doug, how do we want to change the start_gdb with a more generic code and > > decide which debugger is to be used via the command line option and/or env > > var? > > > > I suggest that we have 'debug:s'

Re: TestServer::start_gdb

2001-07-09 Thread Doug MacEachern
On Sun, 8 Jul 2001, Stas Bekman wrote: > > Doug, how do we want to change the start_gdb with a more generic code and > decide which debugger is to be used via the command line option and/or env > var? > > I suggest that we have 'debug:s' option, where: > > --debug > > (no value) uses $ENV{MP